Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: cloud_print/service/service.gyp

Issue 686683004: clang/win: Disable -Wwritable-strings for most cloud_print service targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cloud_print/service/service.gyp
diff --git a/cloud_print/service/service.gyp b/cloud_print/service/service.gyp
index afc1e8fdaa48b1ccbba6892f78a0a73e19cc8b0c..6fd20b845846ad5f4e1572da44fe4231471dd50b 100644
--- a/cloud_print/service/service.gyp
+++ b/cloud_print/service/service.gyp
@@ -69,6 +69,25 @@
'<(DEPTH)/chrome/common_constants.gyp:common_constants',
],
}],
+ ['OS=="win" and clang==1', {
+ # service_controller.h uses DECLARE_REGISTRY_APPID_RESOURCEID, which
+ # in msvs2013 returns string literals via a non-const pointer. So
+ # disable this warning for now.
+ # TODO(thakis): Remove this once we're on 2014,
+ # https://connect.microsoft.com/VisualStudio/feedback/details/806376/atl-hindrances-to-adopting-new-strictstrings-conformance-option-in-vs2013
+ 'msvs_settings': {
+ 'VCCLCompilerTool': {
+ 'AdditionalOptions': ['-Wno-writable-strings'],
+ },
+ },
+ 'direct_dependent_settings': {
+ 'msvs_settings': {
+ 'VCCLCompilerTool': {
+ 'AdditionalOptions': ['-Wno-writable-strings'],
+ },
+ },
+ },
+ }],
['enable_printing!=0', {
'dependencies': [
'<(DEPTH)/printing/printing.gyp:printing',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698