Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 686673002: Correcting suggestion popup width on orientation change (Closed)

Created:
6 years, 1 month ago by ankit
Modified:
6 years, 1 month ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

On orientation change suggestion popup width was setting to some different value then initial value. On layout change the width is reset to url field width but initially width is set to toolbar width. BUG= Committed: https://crrev.com/2e5a62d611b63096f8acff505a743b007bbe5db5 Cr-Commit-Position: refs/heads/master@{#301618}

Patch Set 1 #

Patch Set 2 : Fixing basic bugs #

Patch Set 3 : Correcting suggestion popup width #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
ankit
@Bernhard PTAL
6 years, 1 month ago (2014-10-28 05:07:25 UTC) #2
Bernhard Bauer
These seem like two unrelated changes. Could we split them up into individual CLs?
6 years, 1 month ago (2014-10-28 09:48:26 UTC) #3
ankit
On 2014/10/28 09:48:26, Bernhard Bauer wrote: > These seem like two unrelated changes. Could we ...
6 years, 1 month ago (2014-10-28 11:08:34 UTC) #4
Bernhard Bauer
lgtm
6 years, 1 month ago (2014-10-28 11:09:07 UTC) #5
ankit
On 2014/10/28 11:09:07, Bernhard Bauer wrote: > lgtm Thanks.
6 years, 1 month ago (2014-10-28 11:09:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686673002/40001
6 years, 1 month ago (2014-10-28 11:11:18 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-28 12:06:55 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 12:07:41 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2e5a62d611b63096f8acff505a743b007bbe5db5
Cr-Commit-Position: refs/heads/master@{#301618}

Powered by Google App Engine
This is Rietveld 408576698