Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp

Issue 686653002: Remove a bunch of fixed position dead code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/rendering/RenderView.cpp ('k') | sky/engine/public/platform/WebLayer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp
diff --git a/sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp b/sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp
index ea1219cac4c8080c0504c53b5f23d3f5e717a941..9c7af6701cc3f65ddd6eb6ec04f8568672bbbb57 100644
--- a/sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp
+++ b/sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp
@@ -921,13 +921,13 @@ void CompositedLayerMapping::updateBackgroundLayerGeometry(const FloatSize& rela
void CompositedLayerMapping::registerScrollingLayers()
{
+ // FIXME(sky): Remove this whole function. I think this doesn't do anything now that we don't support position:fixed.
+
// Register fixed position layers and their containers with the scrolling coordinator.
ScrollingCoordinator* scrollingCoordinator = scrollingCoordinatorFromLayer(m_owningLayer);
if (!scrollingCoordinator)
return;
- scrollingCoordinator->updateLayerPositionConstraint(&m_owningLayer);
-
// Page scale is applied as a transform on the root render view layer. Because the scroll
// layer is further up in the hierarchy, we need to avoid marking the root render view
// layer as a container.
« no previous file with comments | « sky/engine/core/rendering/RenderView.cpp ('k') | sky/engine/public/platform/WebLayer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698