Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: ui/app_list/folder_image_source.cc

Issue 686633003: Improved appearance of app list folders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@app-list-factor-folderimagesource
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/app_list/app_list_constants.cc ('K') | « ui/app_list/app_list_constants.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/folder_image_source.cc
diff --git a/ui/app_list/folder_image_source.cc b/ui/app_list/folder_image_source.cc
index ac3f1089277cadf3ae48990a3f53ba8b2b76f135..b454faa22e49b373fc16fdf425b66c04bc91eb0e 100644
--- a/ui/app_list/folder_image_source.cc
+++ b/ui/app_list/folder_image_source.cc
@@ -88,13 +88,21 @@ void FolderImageSource::DrawIcon(gfx::Canvas* canvas,
}
void FolderImageSource::Draw(gfx::Canvas* canvas) {
- // Draw folder circle.
- gfx::Point center = gfx::Point(size().width() / 2, size().height() / 2);
+ // Draw folder circles.
+ // Shadow.
calamity 2014/10/28 06:30:17 // Draw circle for folder shadow.
Matt Giuca 2014/10/28 07:55:13 Done.
+ gfx::PointF center(size().width() / 2, size().height() / 2);
SkPaint paint;
paint.setStyle(SkPaint::kFill_Style);
paint.setAntiAlias(true);
+ paint.setColor(kFolderShadowColor);
+ canvas->sk_canvas()->drawCircle(
+ center.x(), center.y(), kFolderShadowRadius, paint);
+ // Bubble.
calamity 2014/10/28 06:30:17 // Draw circle for folder bubble. (Is bubble the
Matt Giuca 2014/10/28 07:55:13 Well it was used before (kFolderBubbleColor) so I
+ center = gfx::PointF(size().width() / 2,
+ size().height() / 2 - kFolderShadowOffsetY);
calamity 2014/10/28 06:30:17 gfx::PointF bubble_center? Then use center.x()/y()
Matt Giuca 2014/10/28 07:55:13 Done.
paint.setColor(kFolderBubbleColor);
- canvas->DrawCircle(center, size().width() / 2, paint);
+ canvas->sk_canvas()->drawCircle(
+ center.x(), center.y(), kFolderBubbleRadius, paint);
if (icons_.size() == 0)
return;
« ui/app_list/app_list_constants.cc ('K') | « ui/app_list/app_list_constants.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698