Improved appearance of app list folders.

Improved appearance of app list folders.

The folder image now consists of a white circle with a grey shadow,
rather than a simple grey circle.

Also slightly darkened the entire app list background from #fafafa to

BUG=425444
Committed: https://crrev.com/8581fe177563610a21bbf844bf859ee58e1ad8ca
Cr-Commit-Position: refs/heads/master@{#301597}

[Matt Giuca, 2014-10-28 03:30:16]

mgiuca@chromium.org changed reviewers:
+ calamity@chromium.org

[Matt Giuca, 2014-10-28 03:30:17]

Screenshots on the bug:
https://code.google.com/p/chromium/issues/detail?id=425444#c7

[Matt Giuca, 2014-10-28 03:30:40]

Hmm, maybe I also need to shrink the icons inside the folder?

[calamity, 2014-10-28 06:30:17]

lgtm. Not sure if you want to shrink the items. Maybe ask kuscher@?

Either way, you can do that in a follow-up.

https://codereview.chromium.org/686633003/diff/1/ui/app_list/app_list_constan...
File ui/app_list/app_list_constants.cc (right):

https://codereview.chromium.org/686633003/diff/1/ui/app_list/app_list_constan...
ui/app_list/app_list_constants.cc:37: const SkColor kFolderBubbleColor =
SkColorSetRGB(0xFF, 0xFF, 0xFF);
Sk_ColorWHITE.

https://codereview.chromium.org/686633003/diff/1/ui/app_list/folder_image_sou...
File ui/app_list/folder_image_source.cc (right):

https://codereview.chromium.org/686633003/diff/1/ui/app_list/folder_image_sou...
ui/app_list/folder_image_source.cc:92: // Shadow.
// Draw circle for folder shadow.

https://codereview.chromium.org/686633003/diff/1/ui/app_list/folder_image_sou...
ui/app_list/folder_image_source.cc:100: // Bubble.
// Draw circle for folder bubble.

(Is bubble the right term?)

https://codereview.chromium.org/686633003/diff/1/ui/app_list/folder_image_sou...
ui/app_list/folder_image_source.cc:102: size().height() / 2 -
kFolderShadowOffsetY);
gfx::PointF bubble_center? Then use center.x()/y().

[Matt Giuca, 2014-10-28 07:55:13]

https://codereview.chromium.org/686633003/diff/1/ui/app_list/app_list_constan...
File ui/app_list/app_list_constants.cc (right):

https://codereview.chromium.org/686633003/diff/1/ui/app_list/app_list_constan...
ui/app_list/app_list_constants.cc:37: const SkColor kFolderBubbleColor =
SkColorSetRGB(0xFF, 0xFF, 0xFF);
On 2014/10/28 06:30:17, calamity wrote:
> Sk_ColorWHITE.

Done.

https://codereview.chromium.org/686633003/diff/1/ui/app_list/folder_image_sou...
File ui/app_list/folder_image_source.cc (right):

https://codereview.chromium.org/686633003/diff/1/ui/app_list/folder_image_sou...
ui/app_list/folder_image_source.cc:92: // Shadow.
On 2014/10/28 06:30:17, calamity wrote:
> // Draw circle for folder shadow.

Done.

https://codereview.chromium.org/686633003/diff/1/ui/app_list/folder_image_sou...
ui/app_list/folder_image_source.cc:100: // Bubble.
Well it was used before (kFolderBubbleColor) so I guess it's as good as any.

https://codereview.chromium.org/686633003/diff/1/ui/app_list/folder_image_sou...
ui/app_list/folder_image_source.cc:102: size().height() / 2 -
kFolderShadowOffsetY);
On 2014/10/28 06:30:17, calamity wrote:
> gfx::PointF bubble_center? Then use center.x()/y().

Done.

[Matt Giuca, 2014-10-28 10:12:43]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-10-28 10:13:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/686633003/40001

[commit-bot: I haz the power, 2014-10-28 11:53:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-28 11:54:34]

Patchset 3 (id:??) landed as
https://crrev.com/8581fe177563610a21bbf844bf859ee58e1ad8ca
Cr-Commit-Position: refs/heads/master@{#301597}