Merge TRUNCDIV and MOD into TRUNCDIV_MOD single operation.

runtime/vm/intermediate_language_ia32.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/intermediate_language.h"
 
 #include "vm/dart_entry.h"
@@ skipping 2275 matching lines @@
       summary->set_out(Location::SameAsFirstInput());
     } else {
       // Both inputs must be writable because they will be untagged.
       summary->set_in(0, Location::RegisterLocation(EAX));
       summary->set_in(1, Location::WritableRegister());
       summary->set_out(Location::SameAsFirstInput());
       // Will be used for sign extension and division.
       summary->set_temp(0, Location::RegisterLocation(EDX));
     }
     return summary;
+  } else if (op_kind() == Token::kTRUNCDIVMOD) {
+    const intptr_t kNumTemps = 1;
+    LocationSummary* summary =
+        new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
+    // Both inputs must be writable because they will be untagged.
+    summary->set_in(0, Location::RegisterLocation(EAX));
+    summary->set_in(1, Location::WritableRegister());
+    summary->set_out(Location::RequiresRegister());
+    // Will be used for sign extension and division.
+    summary->set_temp(0, Location::RegisterLocation(EDX));
+    return summary;
   } else if (op_kind() == Token::kMOD) {
     const intptr_t kNumTemps = 1;
     LocationSummary* summary =
         new LocationSummary(kNumInputs, kNumTemps, LocationSummary::kNoCall);
     // Both inputs must be writable because they will be untagged.
     summary->set_in(0, Location::RegisterLocation(EDX));
     summary->set_in(1, Location::WritableRegister());
     summary->set_out(Location::SameAsFirstInput());
     // Will be used for sign extension and division.
     summary->set_temp(0, Location::RegisterLocation(EAX));
@@ skipping 36 matching lines @@
 
 void BinarySmiOpInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   if (op_kind() == Token::kSHL) {
     EmitSmiShiftLeft(compiler, this);
     return;
   }
 
   ASSERT(!is_truncating());
   Register left = locs()->in(0).reg();
   Register result = locs()->out().reg();
-  ASSERT(left == result);
+  // DIVMOD is different.
+  ASSERT((op_kind() == Token::kTRUNCDIVMOD) || (left == result));
   Label* deopt = NULL;
   if (CanDeoptimize()) {
     deopt  = compiler->AddDeoptStub(deopt_id(), kDeoptBinarySmiOp);
   }
 
   if (locs()->in(1).IsConstant()) {
     const Object& constant = locs()->in(1).constant();
     ASSERT(constant.IsSmi());
     const int32_t imm =
         reinterpret_cast<int32_t>(constant.raw());
@@ skipping 214 matching lines @@
       __ cmpl(right, Immediate(0));
       __ j(LESS, &subtract, Assembler::kNearJump);
       __ addl(result, right);
       __ jmp(&done, Assembler::kNearJump);
       __ Bind(&subtract);
       __ subl(result, right);
       __ Bind(&done);
       __ SmiTag(result);
       break;
     }
+    case Token::kTRUNCDIVMOD: {
+      // Handle divide by zero in runtime.
+      __ testl(right, right);
+      __ j(ZERO, deopt);
+      ASSERT(left == EAX);
+      ASSERT((right != EDX) && (right != EAX));
+      ASSERT(locs()->temp(0).reg() == EDX);
+      ASSERT((result != EDX) && (result != EAX));
+      __ SmiUntag(left);
+      __ SmiUntag(right);
+      __ cdq();  // Sign extend EAX -> EDX:EAX.
+      __ idivl(right);  //  EAX: quotient, EDX: remainder.
+      // Check the corner case of dividing the 'MIN_SMI' with -1, in which
+      // case we cannot tag the result.
+      // TODO(srdjan): We could store instead untagged intermediate results in a
+      // typed array, but then the load indexed instructions would need to be
+      // able to deoptimize.
+      __ cmpl(EAX, Immediate(0x40000000));
+      __ j(EQUAL, deopt);
+      // Modulo result (EDX) correction:
+      //  res = left % right;
+      //  if (res < 0) {
+      //    if (right < 0) {
+      //      res = res - right;
+      //    } else {
+      //      res = res + right;
+      //    }
+      //  }
+      Label subtract, done;
+      __ cmpl(EDX, Immediate(0));
+      __ j(GREATER_EQUAL, &done, Assembler::kNearJump);
+      // Result is negative, adjust it.
+      __ cmpl(right, Immediate(0));
+      __ j(LESS, &subtract, Assembler::kNearJump);
+      __ addl(EDX, right);
+      __ jmp(&done, Assembler::kNearJump);
+      __ Bind(&subtract);
+      __ subl(EDX, right);
+      __ Bind(&done);
+
+      __ LoadObject(result, Array::ZoneHandle(Array::New(2, Heap::kOld)));
+      const intptr_t index_scale = FlowGraphCompiler::ElementSizeFor(kArrayCid);
+      Address trunc_div_address(
+          FlowGraphCompiler::ElementAddressForIntIndex(kArrayCid,
+                                                       index_scale,
+                                                       result,
+                                                       0));
+      Address mod_address(
+          FlowGraphCompiler::ElementAddressForIntIndex(kArrayCid,
+                                                       index_scale,
+                                                       result,
+                                                       1));
+      __ SmiTag(EAX);
+      __ SmiTag(EDX);
+      __ StoreIntoObjectNoBarrier(result, trunc_div_address, EAX);
+      __ StoreIntoObjectNoBarrier(result, mod_address, EDX);
+      break;
+    }
     case Token::kSHR: {
       if (CanDeoptimize()) {
         __ cmpl(right, Immediate(0));
         __ j(LESS, deopt);
       }
       __ SmiUntag(right);
       // sarl operation masks the count to 5 bits.
       const intptr_t kCountLimit = 0x1F;
       Range* right_range = this->right()->definition()->range();
       if ((right_range == NULL) ||
@@ skipping 2370 matching lines @@
                          PcDescriptors::kOther,
                          locs());
   __ Drop(2);  // Discard type arguments and receiver.
 }
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_IA32