ash/wm/maximize_mode/maximize_mode_window_state.h - Issue 686593002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/maximize_mode/maximize_mode_window_state.h

Issue 686593002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc ('k') | ash/wm/maximize_mode/scoped_disable_internal_mouse_and_keyboard_x11.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/wm/maximize_mode/maximize_mode_window_state.h

diff --git a/ash/wm/maximize_mode/maximize_mode_window_state.h b/ash/wm/maximize_mode/maximize_mode_window_state.h

index 19344b1df64d95345713f3df8dcbc585ef29a5a6..0512bbadf39f386430b19e45e75704b0115cabdd 100644

--- a/ash/wm/maximize_mode/maximize_mode_window_state.h

+++ b/ash/wm/maximize_mode/maximize_mode_window_state.h

@@ -26,7 +26,7 @@ class MaximizeModeWindowState : public wm::WindowState::State {

// was reverted to the old window manager.

MaximizeModeWindowState(aura::Window* window,

MaximizeModeWindowManager* creator);

- virtual ~MaximizeModeWindowState();

+ ~MaximizeModeWindowState() override;

// Leaves the maximize mode by reverting to previous state object.

void LeaveMaximizeMode(wm::WindowState* window_state);

@@ -36,13 +36,13 @@ class MaximizeModeWindowState : public wm::WindowState::State {

void SetDeferBoundsUpdates(bool defer_bounds_updates);

// WindowState::State overrides:

- virtual void OnWMEvent(wm::WindowState* window_state,

- const wm::WMEvent* event) override;

+ void OnWMEvent(wm::WindowState* window_state,

+ const wm::WMEvent* event) override;

- virtual wm::WindowStateType GetType() const override;

- virtual void AttachState(wm::WindowState* window_state,

- wm::WindowState::State* previous_state) override;

- virtual void DetachState(wm::WindowState* window_state) override;

+ wm::WindowStateType GetType() const override;

+ void AttachState(wm::WindowState* window_state,

+ wm::WindowState::State* previous_state) override;

+ void DetachState(wm::WindowState* window_state) override;

private:

// Updates the window to |new_state_type| and resulting bounds: