Issue 686573002: Re-add suppressions for magnifier and dropshadow GMs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 686573002: Re-add suppressions for magnifier and dropshadow GMs. (Closed)

Created:
6 years, 1 month ago by Stephen White

Modified:
6 years, 1 month ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Re-add suppressions for magnifier and dropshadow GMs. Brian's change has invalidated the new baselines, so they'll need to be rebaselined again once his changed has worked its way through. TBR=bsalomon NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/fa4689d56384da5bb264a480e636fac126fb93ca

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	expectations/gm/ignored-tests.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686573002/1

6 years, 1 month ago (2014-10-27 21:26:16 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as fa4689d56384da5bb264a480e636fac126fb93ca

6 years, 1 month ago (2014-10-27 21:26:30 UTC) #3

hcm

6 years, 1 month ago (2014-10-28 03:48:20 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/679413002/ by hcm@google.com.

The reason for reverting is: Trying to get revert of patchset potentially
causing failures on image filter tests.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages