chrome/browser/sync/test/integration/dictionary_helper.cc - Issue 686563003: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/dictionary_helper.cc

Issue 686563003: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/cross_platform_sync_test.cc ('k') | chrome/browser/sync/test/integration/dictionary_load_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/dictionary_helper.cc

diff --git a/chrome/browser/sync/test/integration/dictionary_helper.cc b/chrome/browser/sync/test/integration/dictionary_helper.cc

index 070b2d8a3491f2e395f0a50ef455f5c33af24f03..038ae36b27d410b00ee1ddde7df1c9b4863bc900 100644

--- a/chrome/browser/sync/test/integration/dictionary_helper.cc

+++ b/chrome/browser/sync/test/integration/dictionary_helper.cc

@@ -104,10 +104,10 @@ namespace {

class DictionaryMatchStatusChecker : public MultiClientStatusChangeChecker {

public:

DictionaryMatchStatusChecker();

- virtual ~DictionaryMatchStatusChecker();

+ ~DictionaryMatchStatusChecker() override;

- virtual bool IsExitConditionSatisfied() override;

- virtual std::string GetDebugMessage() const override;

+ bool IsExitConditionSatisfied() override;

+ std::string GetDebugMessage() const override;

};

DictionaryMatchStatusChecker::DictionaryMatchStatusChecker()

@@ -129,10 +129,11 @@ class NumDictionaryEntriesStatusChecker

: public SingleClientStatusChangeChecker {

public:

NumDictionaryEntriesStatusChecker(int index, size_t num_words);

- virtual ~NumDictionaryEntriesStatusChecker();

+ ~NumDictionaryEntriesStatusChecker() override;

+ bool IsExitConditionSatisfied() override;

+ std::string GetDebugMessage() const override;

- virtual bool IsExitConditionSatisfied() override;

- virtual std::string GetDebugMessage() const override;

private:

int index_;

size_t num_words_;