chrome/browser/sync/sync_startup_tracker_unittest.cc - Issue 686563003: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/sync_startup_tracker_unittest.cc

Issue 686563003: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/sync_global_error_unittest.cc ('k') | chrome/browser/sync/test/integration/cross_platform_sync_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/sync_startup_tracker_unittest.cc

diff --git a/chrome/browser/sync/sync_startup_tracker_unittest.cc b/chrome/browser/sync/sync_startup_tracker_unittest.cc

index 8b1d907bce830f0998c2259e7b768ad04a25d561..77bf8e86d239ef4061f6b51f45b739947c56cf53 100644

--- a/chrome/browser/sync/sync_startup_tracker_unittest.cc

+++ b/chrome/browser/sync/sync_startup_tracker_unittest.cc

@@ -29,7 +29,7 @@ class SyncStartupTrackerTest : public testing::Test {

SyncStartupTrackerTest() :

no_error_(GoogleServiceAuthError::NONE) {

}

- virtual void SetUp() override {

+ void SetUp() override {

profile_.reset(new TestingProfile());

mock_pss_ = static_cast<ProfileSyncServiceMock*>(

ProfileSyncServiceFactory::GetInstance()->SetTestingFactoryAndUse(

@@ -47,9 +47,7 @@ class SyncStartupTrackerTest : public testing::Test {

mock_pss_->Initialize();

}

- virtual void TearDown() override {

- profile_.reset();

- }

+ void TearDown() override { profile_.reset(); }

void SetupNonInitializedPSS() {

EXPECT_CALL(*mock_pss_, GetAuthError())