Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Side by Side Diff: chrome/browser/sync/glue/favicon_cache_unittest.cc

Issue 686563003: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/glue/favicon_cache.h" 5 #include "chrome/browser/sync/glue/favicon_cache.h"
6 6
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/strings/stringprintf.h" 9 #include "base/strings/stringprintf.h"
10 #include "base/time/time.h" 10 #include "base/time/time.h"
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 if (!base::StringToInt(temp, &result)) 252 if (!base::StringToInt(temp, &result))
253 return -1; 253 return -1;
254 return result; 254 return result;
255 } 255 }
256 256
257 } // namespace 257 } // namespace
258 258
259 class SyncFaviconCacheTest : public testing::Test { 259 class SyncFaviconCacheTest : public testing::Test {
260 public: 260 public:
261 SyncFaviconCacheTest(); 261 SyncFaviconCacheTest();
262 virtual ~SyncFaviconCacheTest() {} 262 ~SyncFaviconCacheTest() override {}
263 263
264 void SetUpInitialSync(const syncer::SyncDataList& initial_image_data, 264 void SetUpInitialSync(const syncer::SyncDataList& initial_image_data,
265 const syncer::SyncDataList& initial_tracking_data); 265 const syncer::SyncDataList& initial_tracking_data);
266 266
267 size_t GetFaviconCount() const; 267 size_t GetFaviconCount() const;
268 size_t GetTaskCount() const; 268 size_t GetTaskCount() const;
269 269
270 testing::AssertionResult ExpectFaviconEquals( 270 testing::AssertionResult ExpectFaviconEquals(
271 const std::string& page_url, 271 const std::string& page_url,
272 const std::string& bytes) const; 272 const std::string& bytes) const;
(...skipping 1658 matching lines...) Expand 10 before | Expand all | Expand 10 after
1931 EXPECT_EQ(changes[4].change_type(), syncer::SyncChange::ACTION_ADD); 1931 EXPECT_EQ(changes[4].change_type(), syncer::SyncChange::ACTION_ADD);
1932 EXPECT_EQ(changes[4].sync_data().GetDataType(), syncer::FAVICON_TRACKING); 1932 EXPECT_EQ(changes[4].sync_data().GetDataType(), syncer::FAVICON_TRACKING);
1933 EXPECT_EQ(kMaxSyncFavicons, GetFaviconId(changes[4])); 1933 EXPECT_EQ(kMaxSyncFavicons, GetFaviconId(changes[4]));
1934 // Expire tracking for favicon[0]. 1934 // Expire tracking for favicon[0].
1935 EXPECT_EQ(changes[5].change_type(), syncer::SyncChange::ACTION_DELETE); 1935 EXPECT_EQ(changes[5].change_type(), syncer::SyncChange::ACTION_DELETE);
1936 EXPECT_EQ(changes[5].sync_data().GetDataType(), syncer::FAVICON_TRACKING); 1936 EXPECT_EQ(changes[5].sync_data().GetDataType(), syncer::FAVICON_TRACKING);
1937 EXPECT_EQ(0, GetFaviconId(changes[5])); 1937 EXPECT_EQ(0, GetFaviconId(changes[5]));
1938 } 1938 }
1939 1939
1940 } // namespace browser_sync 1940 } // namespace browser_sync
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698