Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h

Issue 686563002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_APP_WINDOW_LAUNCHER_ITEM_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_APP_WINDOW_LAUNCHER_ITEM_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_ASH_LAUNCHER_APP_WINDOW_LAUNCHER_ITEM_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_ASH_LAUNCHER_APP_WINDOW_LAUNCHER_ITEM_CONTROLLER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <string> 9 #include <string>
10 10
(...skipping 23 matching lines...) Expand all
34 // 34 //
35 // Tests are in chrome_launcher_controller_browsertest.cc 35 // Tests are in chrome_launcher_controller_browsertest.cc
36 class AppWindowLauncherItemController : public LauncherItemController, 36 class AppWindowLauncherItemController : public LauncherItemController,
37 public aura::WindowObserver { 37 public aura::WindowObserver {
38 public: 38 public:
39 AppWindowLauncherItemController(Type type, 39 AppWindowLauncherItemController(Type type,
40 const std::string& app_shelf_id, 40 const std::string& app_shelf_id,
41 const std::string& app_id, 41 const std::string& app_id,
42 ChromeLauncherController* controller); 42 ChromeLauncherController* controller);
43 43
44 virtual ~AppWindowLauncherItemController(); 44 ~AppWindowLauncherItemController() override;
45 45
46 void AddAppWindow(extensions::AppWindow* app_window, 46 void AddAppWindow(extensions::AppWindow* app_window,
47 ash::ShelfItemStatus status); 47 ash::ShelfItemStatus status);
48 48
49 void RemoveAppWindowForWindow(aura::Window* window); 49 void RemoveAppWindowForWindow(aura::Window* window);
50 50
51 void SetActiveWindow(aura::Window* window); 51 void SetActiveWindow(aura::Window* window);
52 52
53 const std::string& app_shelf_id() const { return app_shelf_id_; } 53 const std::string& app_shelf_id() const { return app_shelf_id_; }
54 54
55 // LauncherItemController overrides: 55 // LauncherItemController overrides:
56 virtual bool IsOpen() const override; 56 bool IsOpen() const override;
57 virtual bool IsVisible() const override; 57 bool IsVisible() const override;
58 virtual void Launch(ash::LaunchSource source, int event_flags) override; 58 void Launch(ash::LaunchSource source, int event_flags) override;
59 virtual bool Activate(ash::LaunchSource source) override; 59 bool Activate(ash::LaunchSource source) override;
60 virtual ChromeLauncherAppMenuItems GetApplicationList(int event_flags) 60 ChromeLauncherAppMenuItems GetApplicationList(int event_flags) override;
61 override; 61 bool ItemSelected(const ui::Event& eent) override;
62 virtual bool ItemSelected(const ui::Event& eent) override; 62 base::string16 GetTitle() override;
63 virtual base::string16 GetTitle() override; 63 ui::MenuModel* CreateContextMenu(aura::Window* root_window) override;
64 virtual ui::MenuModel* CreateContextMenu(aura::Window* root_window) override; 64 ash::ShelfMenuModel* CreateApplicationMenu(int event_flags) override;
65 virtual ash::ShelfMenuModel* CreateApplicationMenu(int event_flags) override; 65 bool IsDraggable() override;
66 virtual bool IsDraggable() override; 66 bool ShouldShowTooltip() override;
67 virtual bool ShouldShowTooltip() override; 67 void Close() override;
68 virtual void Close() override;
69 68
70 // aura::WindowObserver overrides: 69 // aura::WindowObserver overrides:
71 virtual void OnWindowPropertyChanged(aura::Window* window, 70 void OnWindowPropertyChanged(aura::Window* window,
72 const void* key, 71 const void* key,
73 intptr_t old) override; 72 intptr_t old) override;
74 73
75 // Get the number of running applications/incarnations of this. 74 // Get the number of running applications/incarnations of this.
76 size_t app_window_count() const { return app_windows_.size(); } 75 size_t app_window_count() const { return app_windows_.size(); }
77 76
78 // Activates the window at position |index|. 77 // Activates the window at position |index|.
79 void ActivateIndexedApp(size_t index); 78 void ActivateIndexedApp(size_t index);
80 79
81 // Install the app. Only valid for ephemeral apps, which can be promoted to 80 // Install the app. Only valid for ephemeral apps, which can be promoted to
82 // regular installed apps. 81 // regular installed apps.
83 void InstallApp(); 82 void InstallApp();
(...skipping 17 matching lines...) Expand all
101 // AppLauncherItemController for each |app_shelf_id_|. 100 // AppLauncherItemController for each |app_shelf_id_|.
102 const std::string app_shelf_id_; 101 const std::string app_shelf_id_;
103 102
104 // Scoped list of observed windows (for removal on destruction) 103 // Scoped list of observed windows (for removal on destruction)
105 ScopedObserver<aura::Window, aura::WindowObserver> observed_windows_; 104 ScopedObserver<aura::Window, aura::WindowObserver> observed_windows_;
106 105
107 DISALLOW_COPY_AND_ASSIGN(AppWindowLauncherItemController); 106 DISALLOW_COPY_AND_ASSIGN(AppWindowLauncherItemController);
108 }; 107 };
109 108
110 #endif // CHROME_BROWSER_UI_ASH_LAUNCHER_APP_WINDOW_LAUNCHER_ITEM_CONTROLLER_H_ 109 #endif // CHROME_BROWSER_UI_ASH_LAUNCHER_APP_WINDOW_LAUNCHER_ITEM_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698