chrome/browser/ui/views/ash/tab_scrubber.h - Issue 686553002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/ash/tab_scrubber.h

Issue 686553002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc ('k') | chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/ash/tab_scrubber.h

diff --git a/chrome/browser/ui/views/ash/tab_scrubber.h b/chrome/browser/ui/views/ash/tab_scrubber.h

index 353e881f2e075bbc4528730038c2dc7df63bd0a1..a4a9a06a16161c7b5cb77d8f61e2349648d7ff0f 100644

--- a/chrome/browser/ui/views/ash/tab_scrubber.h

+++ b/chrome/browser/ui/views/ash/tab_scrubber.h

@@ -48,23 +48,23 @@ class TabScrubber : public ui::EventHandler,

private:

TabScrubber();

- virtual ~TabScrubber();

+ ~TabScrubber() override;

// ui::EventHandler overrides:

- virtual void OnScrollEvent(ui::ScrollEvent* event) override;

+ void OnScrollEvent(ui::ScrollEvent* event) override;

// content::NotificationObserver overrides:

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

// TabStripObserver overrides.

- virtual void TabStripAddedTabAt(TabStrip* tab_strip, int index) override;

- virtual void TabStripMovedTab(TabStrip* tab_strip,

- int from_index,

- int to_index) override;

- virtual void TabStripRemovedTabAt(TabStrip* tab_strip, int index) override;

- virtual void TabStripDeleted(TabStrip* tab_strip) override;

+ void TabStripAddedTabAt(TabStrip* tab_strip, int index) override;

+ void TabStripMovedTab(TabStrip* tab_strip,

+ int from_index,

+ int to_index) override;

+ void TabStripRemovedTabAt(TabStrip* tab_strip, int index) override;

+ void TabStripDeleted(TabStrip* tab_strip) override;

Browser* GetActiveBrowser();

void FinishScrub(bool activate);