chrome/browser/ui/views/download/download_in_progress_dialog_view.h - Issue 686533002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/download/download_in_progress_dialog_view.h

Issue 686533002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/download/download_feedback_dialog_view.cc ('k') | chrome/browser/ui/views/download/download_item_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/download/download_in_progress_dialog_view.h

diff --git a/chrome/browser/ui/views/download/download_in_progress_dialog_view.h b/chrome/browser/ui/views/download/download_in_progress_dialog_view.h

index 87fc82baee91801a27cbc77e97f1bde5b87a167a..e685748f667444e1888d8a8a6eafcc6a3a466080 100644

--- a/chrome/browser/ui/views/download/download_in_progress_dialog_view.h

+++ b/chrome/browser/ui/views/download/download_in_progress_dialog_view.h

@@ -27,22 +27,21 @@ class DownloadInProgressDialogView : public views::DialogDelegate {

Browser::DownloadClosePreventionType dialog_type,

bool app_modal,

const base::Callback<void(bool)>& callback);

- virtual ~DownloadInProgressDialogView();

+ ~DownloadInProgressDialogView() override;

// views::DialogDelegate:

- virtual int GetDefaultDialogButton() const override;

- virtual base::string16 GetDialogButtonLabel(

- ui::DialogButton button) const override;

- virtual bool Cancel() override;

- virtual bool Accept() override;

+ int GetDefaultDialogButton() const override;

+ base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;

+ bool Cancel() override;

+ bool Accept() override;

// views::WidgetDelegate:

- virtual ui::ModalType GetModalType() const override;

- virtual base::string16 GetWindowTitle() const override;

- virtual void DeleteDelegate() override;

- virtual views::Widget* GetWidget() override;

- virtual const views::Widget* GetWidget() const override;

- virtual views::View* GetContentsView() override;

+ ui::ModalType GetModalType() const override;

+ base::string16 GetWindowTitle() const override;

+ void DeleteDelegate() override;

+ views::Widget* GetWidget() override;

+ const views::Widget* GetWidget() const override;

+ views::View* GetContentsView() override;

const bool app_modal_;

const base::Callback<void(bool)> callback_;