content/renderer/v8_value_converter_impl_unittest.cc - Issue 686523002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/v8_value_converter_impl_unittest.cc

Issue 686523002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/screen_orientation/screen_orientation_dispatcher_unittest.cc ('k') | content/shell/app/shell_crash_reporter_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/v8_value_converter_impl_unittest.cc

diff --git a/content/renderer/v8_value_converter_impl_unittest.cc b/content/renderer/v8_value_converter_impl_unittest.cc

index 2b44b1296f2a1bd0d75e973005f2a6344d39501c..5cd30a9f29163df20cf1bb2a04574fab787c14c8 100644

--- a/content/renderer/v8_value_converter_impl_unittest.cc

+++ b/content/renderer/v8_value_converter_impl_unittest.cc

@@ -51,15 +51,13 @@ class V8ValueConverterImplTest : public testing::Test {

}

protected:

- virtual void SetUp() {

+ void SetUp() override {

v8::HandleScope handle_scope(isolate_);

v8::Handle<v8::ObjectTemplate> global = v8::ObjectTemplate::New(isolate_);

context_.Reset(isolate_, v8::Context::New(isolate_, NULL, global));

}

- virtual void TearDown() {

- context_.Reset();

- }

+ void TearDown() override { context_.Reset(); }

std::string GetString(base::DictionaryValue* value, const std::string& key) {

std::string temp;