content/renderer/media/rtc_video_decoder_unittest.cc - Issue 686523002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_video_decoder_unittest.cc

Issue 686523002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/rtc_peer_connection_handler_unittest.cc ('k') | content/renderer/media/user_media_client_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/rtc_video_decoder_unittest.cc

diff --git a/content/renderer/media/rtc_video_decoder_unittest.cc b/content/renderer/media/rtc_video_decoder_unittest.cc

index 3c43e7602e06ec39059b3b89004f19719ade566c..4500355bdd61a6bfc83da04c325ffdc59fed585a 100644

--- a/content/renderer/media/rtc_video_decoder_unittest.cc

+++ b/content/renderer/media/rtc_video_decoder_unittest.cc

@@ -31,7 +31,7 @@ class RTCVideoDecoderTest : public ::testing::Test,

memset(&codec_, 0, sizeof(codec_));

}

- virtual void SetUp() override {

+ void SetUp() override {

ASSERT_TRUE(vda_thread_.Start());

vda_task_runner_ = vda_thread_.message_loop_proxy();

mock_vda_ = new media::MockVideoDecodeAccelerator;

@@ -47,7 +47,7 @@ class RTCVideoDecoderTest : public ::testing::Test,

EXPECT_CALL(*mock_vda_, Destroy()).Times(1);

}

- virtual void TearDown() override {

+ void TearDown() override {

VLOG(2) << "TearDown";

EXPECT_TRUE(vda_thread_.IsRunning());

RunUntilIdle(); // Wait until all callbascks complete.