content/renderer/gpu/gpu_benchmarking_extension.h - Issue 686523002: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/gpu/gpu_benchmarking_extension.h

Issue 686523002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/gpu/gpu_benchmarking_extension.h

diff --git a/content/renderer/gpu/gpu_benchmarking_extension.h b/content/renderer/gpu/gpu_benchmarking_extension.h

index d657e91a1422df183865bc131654df330ef90322..d4736dd840e47e2a6ebbfe41785ac03b02cb4628 100644

--- a/content/renderer/gpu/gpu_benchmarking_extension.h

+++ b/content/renderer/gpu/gpu_benchmarking_extension.h

@@ -33,10 +33,10 @@ class GpuBenchmarking : public gin::Wrappable<GpuBenchmarking> {

private:

GpuBenchmarking();

- virtual ~GpuBenchmarking();

+ ~GpuBenchmarking() override;

// gin::Wrappable.

- virtual gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

+ gin::ObjectTemplateBuilder GetObjectTemplateBuilder(

v8::Isolate* isolate) override;

// JavaScript handlers.

« no previous file with comments | « content/renderer/gin_browsertest.cc ('k') | content/renderer/gpu/queue_message_swap_promise_unittest.cc » ('j') | no next file with comments »