Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: content/renderer/manifest/manifest_parser_unittest.cc

Issue 686523002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/manifest/manifest_parser.h" 5 #include "content/renderer/manifest/manifest_parser.h"
6 6
7 #include "base/strings/string_util.h" 7 #include "base/strings/string_util.h"
8 #include "content/public/common/manifest.h" 8 #include "content/public/common/manifest.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 namespace content { 11 namespace content {
12 12
13 class ManifestParserTest : public testing::Test { 13 class ManifestParserTest : public testing::Test {
14 protected: 14 protected:
15 ManifestParserTest() {} 15 ManifestParserTest() {}
16 virtual ~ManifestParserTest() {} 16 ~ManifestParserTest() override {}
17 17
18 Manifest ParseManifest(const base::StringPiece& json, 18 Manifest ParseManifest(const base::StringPiece& json,
19 const GURL& document_url = default_document_url, 19 const GURL& document_url = default_document_url,
20 const GURL& manifest_url = default_manifest_url) { 20 const GURL& manifest_url = default_manifest_url) {
21 return ManifestParser::Parse(json, document_url, manifest_url); 21 return ManifestParser::Parse(json, document_url, manifest_url);
22 } 22 }
23 23
24 static const GURL default_document_url; 24 static const GURL default_document_url;
25 static const GURL default_manifest_url; 25 static const GURL default_manifest_url;
26 26
(...skipping 571 matching lines...) Expand 10 before | Expand all | Expand 10 after
598 Manifest manifest = ParseManifest("{ \"gcm_sender_id\": {} }"); 598 Manifest manifest = ParseManifest("{ \"gcm_sender_id\": {} }");
599 EXPECT_TRUE(manifest.gcm_sender_id.is_null()); 599 EXPECT_TRUE(manifest.gcm_sender_id.is_null());
600 } 600 }
601 { 601 {
602 Manifest manifest = ParseManifest("{ \"gcm_sender_id\": 42 }"); 602 Manifest manifest = ParseManifest("{ \"gcm_sender_id\": 42 }");
603 EXPECT_TRUE(manifest.gcm_sender_id.is_null()); 603 EXPECT_TRUE(manifest.gcm_sender_id.is_null());
604 } 604 }
605 } 605 }
606 606
607 } // namespace content 607 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/input/input_event_filter_unittest.cc ('k') | content/renderer/media/crypto/key_systems_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698