Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: ui/views/widget/desktop_aura/desktop_screen_position_client.h

Issue 686513004: Creating default implementation for aura::client::ScreenPositionClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing unwanted change. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/desktop_aura/desktop_screen_position_client.h
diff --git a/ui/views/widget/desktop_aura/desktop_screen_position_client.h b/ui/views/widget/desktop_aura/desktop_screen_position_client.h
index 890a5c1c90dbf599543a5149fa3e95cf3d88b444..929c7fabf3cbe9f0b9868d1e00c66bb59b5657cb 100644
--- a/ui/views/widget/desktop_aura/desktop_screen_position_client.h
+++ b/ui/views/widget/desktop_aura/desktop_screen_position_client.h
@@ -5,30 +5,27 @@
#ifndef UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_SCREEN_POSITION_CLIENT_H_
#define UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_SCREEN_POSITION_CLIENT_H_
-#include "ui/aura/client/screen_position_client.h"
#include "ui/views/views_export.h"
+#include "ui/wm/core/default_screen_position_client.h"
namespace views {
// Client that always offsets by the toplevel RootWindow of the passed
// in child NativeWidgetAura.
class VIEWS_EXPORT DesktopScreenPositionClient
- : public aura::client::ScreenPositionClient {
+ : public wm::DefaultScreenPositionClient {
public:
explicit DesktopScreenPositionClient(aura::Window* root_window);
~DesktopScreenPositionClient() override;
- // aura::client::ScreenPositionClient overrides:
- void ConvertPointToScreen(const aura::Window* window,
- gfx::Point* point) override;
- void ConvertPointFromScreen(const aura::Window* window,
- gfx::Point* point) override;
- void ConvertHostPointToScreen(aura::Window* window,
- gfx::Point* point) override;
+ // aura::client::DefaultScreenPositionClient:
void SetBounds(aura::Window* window,
const gfx::Rect& bounds,
const gfx::Display& display) override;
+ protected:
+ bool PositionWindowInScreenCoordinates(aura::Window* window) override;
+
private:
aura::Window* root_window_;

Powered by Google App Engine
This is Rietveld 408576698