Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3968)

Unified Diff: athena/screen/screen_manager_impl.cc

Issue 686513004: Creating default implementation for aura::client::ScreenPositionClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 1 -> 1.0f Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_aura_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: athena/screen/screen_manager_impl.cc
diff --git a/athena/screen/screen_manager_impl.cc b/athena/screen/screen_manager_impl.cc
index bb332122b0b445d6960e668d9ac0fffdc7f1ddea..471df3b29d5b3a618bd68a0473396f4f4f00776c 100644
--- a/athena/screen/screen_manager_impl.cc
+++ b/athena/screen/screen_manager_impl.cc
@@ -22,6 +22,7 @@
#include "ui/gfx/screen.h"
#include "ui/wm/core/base_focus_rules.h"
#include "ui/wm/core/capture_controller.h"
+#include "ui/wm/core/default_screen_position_client.h"
#include "ui/wm/core/focus_controller.h"
#include "ui/wm/core/window_util.h"
@@ -120,7 +121,7 @@ class AthenaFocusRules : public wm::BaseFocusRules {
DISALLOW_COPY_AND_ASSIGN(AthenaFocusRules);
};
-class AthenaScreenPositionClient : public aura::client::ScreenPositionClient {
+class AthenaScreenPositionClient : public wm::DefaultScreenPositionClient {
public:
AthenaScreenPositionClient() {
}
@@ -128,30 +129,12 @@ class AthenaScreenPositionClient : public aura::client::ScreenPositionClient {
private:
// aura::client::ScreenPositionClient:
- virtual void ConvertPointToScreen(const aura::Window* window,
- gfx::Point* point) override {
- const aura::Window* root = window->GetRootWindow();
- aura::Window::ConvertPointToTarget(window, root, point);
- }
-
- virtual void ConvertPointFromScreen(const aura::Window* window,
- gfx::Point* point) override {
- const aura::Window* root = window->GetRootWindow();
- aura::Window::ConvertPointToTarget(root, window, point);
- }
-
- virtual void ConvertHostPointToScreen(aura::Window* window,
- gfx::Point* point) override {
+ void ConvertHostPointToScreen(aura::Window* window,
+ gfx::Point* point) override {
// TODO(oshima): Implement this when adding multiple display support.
NOTREACHED();
}
- virtual void SetBounds(aura::Window* window,
- const gfx::Rect& bounds,
- const gfx::Display& display) override {
- window->SetBounds(bounds);
- }
-
DISALLOW_COPY_AND_ASSIGN(AthenaScreenPositionClient);
};
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_aura_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698