Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Unified Diff: ui/views/widget/desktop_aura/desktop_screen_position_client.cc

Issue 686513004: Creating default implementation for aura::client::ScreenPositionClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Implementing review feedback Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/desktop_aura/desktop_screen_position_client.cc
diff --git a/ui/views/widget/desktop_aura/desktop_screen_position_client.cc b/ui/views/widget/desktop_aura/desktop_screen_position_client.cc
index 96deaf4205c58fdb47424eb823a50cb99104bd4b..e7ec734d79c5ccd948ee08709f2709402349f73f 100644
--- a/ui/views/widget/desktop_aura/desktop_screen_position_client.cc
+++ b/ui/views/widget/desktop_aura/desktop_screen_position_client.cc
@@ -4,26 +4,14 @@
#include "ui/views/widget/desktop_aura/desktop_screen_position_client.h"
-#include "ui/aura/window_tree_host.h"
-#include "ui/gfx/display.h"
-#include "ui/gfx/point_conversions.h"
-#include "ui/gfx/screen.h"
#include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h"
namespace views {
namespace {
-gfx::Point GetOrigin(const aura::Window* root_window) {
- gfx::Point origin_in_pixels = root_window->GetHost()->GetBounds().origin();
- aura::Window* window = const_cast<aura::Window*>(root_window);
- float scale = gfx::Screen::GetScreenFor(window)->
- GetDisplayNearestWindow(window).device_scale_factor();
- return gfx::ToFlooredPoint(gfx::ScalePoint(origin_in_pixels, 1 / scale));
-}
-
-// Returns true if bounds passed to window are treated as though they are in
-// screen coordinates.
+// Returns true if bounds passed to window in SetBounds should be treated as
+// though they are in screen coordinates.
bool PositionWindowInScreenCoordinates(aura::Window* window) {
if (window->type() == ui::wm::WINDOW_TYPE_POPUP)
return true;
@@ -36,7 +24,7 @@ bool PositionWindowInScreenCoordinates(aura::Window* window) {
DesktopScreenPositionClient::DesktopScreenPositionClient(
aura::Window* root_window)
- : root_window_(root_window) {
+ : wm::DefaultScreenPositionClient(), root_window_(root_window) {
aura::client::SetScreenPositionClient(root_window_, this);
}
@@ -44,34 +32,10 @@ DesktopScreenPositionClient::~DesktopScreenPositionClient() {
aura::client::SetScreenPositionClient(root_window_, NULL);
}
-void DesktopScreenPositionClient::ConvertPointToScreen(
- const aura::Window* window,
- gfx::Point* point) {
- const aura::Window* root_window = window->GetRootWindow();
- aura::Window::ConvertPointToTarget(window, root_window, point);
- gfx::Point origin = GetOrigin(root_window);
- point->Offset(origin.x(), origin.y());
-}
-
-void DesktopScreenPositionClient::ConvertPointFromScreen(
- const aura::Window* window,
- gfx::Point* point) {
- const aura::Window* root_window = window->GetRootWindow();
- gfx::Point origin = GetOrigin(root_window);
- point->Offset(-origin.x(), -origin.y());
- aura::Window::ConvertPointToTarget(root_window, window, point);
-}
-
-void DesktopScreenPositionClient::ConvertHostPointToScreen(aura::Window* window,
- gfx::Point* point) {
- aura::Window* root_window = window->GetRootWindow();
- ConvertPointToScreen(root_window, point);
-}
-
void DesktopScreenPositionClient::SetBounds(aura::Window* window,
const gfx::Rect& bounds,
const gfx::Display& display) {
- // TODO: Use the 3rd parameter, |display|.
+ // TODO(jam): Use the 3rd parameter, |display|.
aura::Window* root = window->GetRootWindow();
// This method assumes that |window| does not have an associated

Powered by Google App Engine
This is Rietveld 408576698