Creating default implementation for aura::client::ScreenPositionClient

ui/wm/core/default_screen_position_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "ui/views/widget/desktop_aura/desktop_screen_position_client.h"
+#include "ui/wm/core/default_screen_position_client.h"
 
 #include "ui/aura/window_tree_host.h"
 #include "ui/gfx/display.h"
 #include "ui/gfx/point_conversions.h"
 #include "ui/gfx/screen.h"
-#include "ui/views/widget/desktop_aura/desktop_native_widget_aura.h"
 
-namespace views {
+namespace wm {
 
 namespace {
 
 gfx::Point GetOrigin(const aura::Window* root_window) {
   gfx::Point origin_in_pixels = root_window->GetHost()->GetBounds().origin();
   aura::Window* window = const_cast<aura::Window*>(root_window);
   float scale = gfx::Screen::GetScreenFor(window)->
        GetDisplayNearestWindow(window).device_scale_factor();
   return gfx::ToFlooredPoint(gfx::ScalePoint(origin_in_pixels, 1 / scale));
 }
 
-// Returns true if bounds passed to window are treated as though they are in
-// screen coordinates.
-bool PositionWindowInScreenCoordinates(aura::Window* window) {
-  if (window->type() == ui::wm::WINDOW_TYPE_POPUP)
-    return true;
-
-  Widget* widget = Widget::GetWidgetForNativeView(window);
-  return widget && widget->is_top_level();
-}
-
 }  // namespace
 
-DesktopScreenPositionClient::DesktopScreenPositionClient(
-    aura::Window* root_window)
-    : root_window_(root_window) {
-  aura::client::SetScreenPositionClient(root_window_, this);
+DefaultScreenPositionClient::DefaultScreenPositionClient() {
 }
 
-DesktopScreenPositionClient::~DesktopScreenPositionClient() {
-  aura::client::SetScreenPositionClient(root_window_, NULL);
+DefaultScreenPositionClient::~DefaultScreenPositionClient() {
 }
 
-void DesktopScreenPositionClient::ConvertPointToScreen(
+bool DefaultScreenPositionClient::PositionWindowInScreenCoordinates(
+    aura::Window* window) {
+  return window->type() == ui::wm::WINDOW_TYPE_POPUP;

[sadrul, 2014/10/30 16:09:11]

Why special case POPUP here?

[mfomitchev, 2014/10/30 20:12:53]

I just copied this code from desktop_native_widget_aura.cc. I guess the
reasoning is that popus are always positioned in screen coordinates.. Should I
just leave this in DesktopScreenPositionClient and not have any such logic in
the default implementation?

[sadrul, 2014/10/30 20:20:07]

Yeah. I think we can do without PositionWindowInScreenCoordinates(). The desktop
implementation overrides ::SetBounds() anyway, and so it can do this check in
there. The default impl of ::SetBounds() below can just do window->SetBounds()

[mfomitchev, 2014/10/30 22:02:12]

Done.

+}
+
+void DefaultScreenPositionClient::ConvertPointToScreen(
     const aura::Window* window,
     gfx::Point* point) {
   const aura::Window* root_window = window->GetRootWindow();
   aura::Window::ConvertPointToTarget(window, root_window, point);
   gfx::Point origin = GetOrigin(root_window);
   point->Offset(origin.x(), origin.y());
 }
 
-void DesktopScreenPositionClient::ConvertPointFromScreen(
+void DefaultScreenPositionClient::ConvertPointFromScreen(
     const aura::Window* window,
     gfx::Point* point) {
   const aura::Window* root_window = window->GetRootWindow();
   gfx::Point origin = GetOrigin(root_window);
   point->Offset(-origin.x(), -origin.y());
   aura::Window::ConvertPointToTarget(root_window, window, point);
 }
 
-void DesktopScreenPositionClient::ConvertHostPointToScreen(aura::Window* window,
+void DefaultScreenPositionClient::ConvertHostPointToScreen(aura::Window* window,
                                                            gfx::Point* point) {
   aura::Window* root_window = window->GetRootWindow();
   ConvertPointToScreen(root_window, point);
 }
 
-void DesktopScreenPositionClient::SetBounds(aura::Window* window,
+void DefaultScreenPositionClient::SetBounds(aura::Window* window,
                                             const gfx::Rect& bounds,
                                             const gfx::Display& display) {
-  // TODO: Use the 3rd parameter, |display|.
-  aura::Window* root = window->GetRootWindow();
+  if (PositionWindowInScreenCoordinates(window)) {
+    aura::Window* root = window->GetRootWindow();
 
-  // This method assumes that |window| does not have an associated
-  // DesktopNativeWidgetAura.
-  internal::NativeWidgetPrivate* desktop_native_widget =
-      DesktopNativeWidgetAura::ForWindow(root);
-  DCHECK(!desktop_native_widget ||
-         desktop_native_widget->GetNativeView() != window);
-
-  if (PositionWindowInScreenCoordinates(window)) {
     // The caller expects windows we consider "embedded" to be placed in the
     // screen coordinate system. So we need to offset the root window's
     // position (which is in screen coordinates) from these bounds.
-
     gfx::Point origin = bounds.origin();
     aura::Window::ConvertPointToTarget(window->parent(), root, &origin);
 
     gfx::Point host_origin = GetOrigin(root);
     origin.Offset(-host_origin.x(), -host_origin.y());
     window->SetBounds(gfx::Rect(origin, bounds.size()));
     return;
   }
 
   window->SetBounds(bounds);
 }
 
-}  // namespace views
+}  // namespace wm