Creating default implementation for aura::client::ScreenPositionClient

ui/wm/core/default_screen_position_client.h

-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_SCREEN_POSITION_CLIENT_H_
-#define UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_SCREEN_POSITION_CLIENT_H_
+#ifndef UI_WM_CORE_DEFAULT_SCREEN_POSITION_CLIENT_H_
+#define UI_WM_CORE_DEFAULT_SCREEN_POSITION_CLIENT_H_
 
 #include "ui/aura/client/screen_position_client.h"
-#include "ui/views/views_export.h"
+#include "ui/wm/wm_export.h"
 
-namespace views {
+namespace wm {
 
 // Client that always offsets by the toplevel RootWindow of the passed
 // in child NativeWidgetAura.
-class VIEWS_EXPORT DesktopScreenPositionClient
+class WM_EXPORT DefaultScreenPositionClient
     : public aura::client::ScreenPositionClient {
  public:
-  explicit DesktopScreenPositionClient(aura::Window* root_window);
-  ~DesktopScreenPositionClient() override;
+  DefaultScreenPositionClient();
+  ~DefaultScreenPositionClient() override;
 
   // aura::client::ScreenPositionClient overrides:
   void ConvertPointToScreen(const aura::Window* window,
                             gfx::Point* point) override;
   void ConvertPointFromScreen(const aura::Window* window,
                               gfx::Point* point) override;
   void ConvertHostPointToScreen(aura::Window* window,
                                 gfx::Point* point) override;
   void SetBounds(aura::Window* window,
                  const gfx::Rect& bounds,
                  const gfx::Display& display) override;
 
+ protected:
+  virtual gfx::Point GetOrigin(const aura::Window* root_window);

[sadrul, 2014/11/03 16:57:22]

This doesn't need to be virtual?

Add a comment explaining that this returns the origin of the host
platform-window in system pixel coordinate (or alternatively, call this
GetOriginInSystemPixels()).

[mfomitchev, 2014/11/03 18:25:07]

Nope, it doesn't. I thought subclasses may want to override, but I guess until
there's a use case for that we can keep it non-virtual.

How about GetOriginInScreen() to make it consistent with the otehr methods? I
added a comment as well.

[sadrul, 2014/11/03 18:48:43]

Yep, sounds good.

+
  private:
-  aura::Window* root_window_;
-
-  DISALLOW_COPY_AND_ASSIGN(DesktopScreenPositionClient);
+  DISALLOW_COPY_AND_ASSIGN(DefaultScreenPositionClient);
 };
 
-}  // namespace views
+}  // namespace wm
 
-#endif  // UI_VIEWS_WIDGET_DESKTOP_AURA_DESKTOP_SCREEN_POSITION_CLIENT_H_
+#endif  // UI_WM_CORE_DEFAULT_SCREEN_POSITION_CLIENT_H_