Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 686473002: Retry dbec51e813: Autofill: Fix recognition of Walmart ZIP code. (Closed)

Created:
6 years, 1 month ago by Evan Stade
Modified:
6 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Retry dbec51e813: Autofill: Fix recognition of Walmart ZIP code. Was reverted due to an in-flight conflict. Now includes update to Macy's test case. TBR=isherman@chromium.org BUG=426958 Committed: https://crrev.com/f49c123851d3b3661336e5f29f0d5b0f60339589 Cr-Commit-Position: refs/heads/master@{#301430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/test/data/autofill/heuristics/output/20_checkout_m_walmart.com.out View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/autofill/heuristics/output/21_checkout_m_macys.com.out View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/address_field.cc View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Evan Stade
6 years, 1 month ago (2014-10-27 18:38:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686473002/1
6 years, 1 month ago (2014-10-27 18:38:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686473002/1
6 years, 1 month ago (2014-10-27 18:39:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 20:14:45 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 20:15:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f49c123851d3b3661336e5f29f0d5b0f60339589
Cr-Commit-Position: refs/heads/master@{#301430}

Powered by Google App Engine
This is Rietveld 408576698