chrome/browser/ui/views/frame/global_menu_bar_x11.h - Issue 686463004: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/global_menu_bar_x11.h

Issue 686463004: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/desktop_browser_frame_aura.h ('k') | chrome/browser/ui/views/frame/immersive_mode_controller_ash.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/global_menu_bar_x11.h

diff --git a/chrome/browser/ui/views/frame/global_menu_bar_x11.h b/chrome/browser/ui/views/frame/global_menu_bar_x11.h

index 93b5bfe9a772e5fe7aa96a8c9c713915bf3c52c9..45cb42e162072d8922593fc99fde09273abcc5d4 100644

--- a/chrome/browser/ui/views/frame/global_menu_bar_x11.h

+++ b/chrome/browser/ui/views/frame/global_menu_bar_x11.h

@@ -58,7 +58,7 @@ class GlobalMenuBarX11 : public AvatarMenuObserver,

public:

GlobalMenuBarX11(BrowserView* browser_view,

BrowserDesktopWindowTreeHostX11* host);

- virtual ~GlobalMenuBarX11();

+ ~GlobalMenuBarX11() override;

// Creates the object path for DbusemenuServer which is attached to |xid|.

static std::string GetPathForWindow(unsigned long xid);

@@ -122,26 +122,26 @@ class GlobalMenuBarX11 : public AvatarMenuObserver,

static void DeleteHistoryItem(void* void_item);

// Overridden from AvatarMenuObserver:

- virtual void OnAvatarMenuChanged(AvatarMenu* avatar_menu) override;

+ void OnAvatarMenuChanged(AvatarMenu* avatar_menu) override;

// Overridden from chrome::BrowserListObserver:

- virtual void OnBrowserSetLastActive(Browser* browser) override;

+ void OnBrowserSetLastActive(Browser* browser) override;

// Overridden from CommandObserver:

- virtual void EnabledStateChangedForCommand(int id, bool enabled) override;

+ void EnabledStateChangedForCommand(int id, bool enabled) override;

// Overridden from content::NotificationObserver:

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

// Overridden from TabRestoreServiceObserver:

- virtual void TabRestoreServiceChanged(TabRestoreService* service) override;

- virtual void TabRestoreServiceDestroyed(TabRestoreService* service) override;

+ void TabRestoreServiceChanged(TabRestoreService* service) override;

+ void TabRestoreServiceDestroyed(TabRestoreService* service) override;

// Overridden from views::DesktopWindowTreeHostObserverX11:

- virtual void OnWindowMapped(unsigned long xid) override;

- virtual void OnWindowUnmapped(unsigned long xid) override;

+ void OnWindowMapped(unsigned long xid) override;

+ void OnWindowUnmapped(unsigned long xid) override;

CHROMEG_CALLBACK_1(GlobalMenuBarX11, void, OnItemActivated, DbusmenuMenuitem*,

unsigned int);