Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 686463002: Add guidelines about what should be in base to base/OWNERS. (Closed)

Created:
6 years, 1 month ago by Nico
Modified:
6 years, 1 month ago
Reviewers:
danakj
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add brettw's guidelines about what should be in base to base/OWNERS. BUG=none NOTRY=true Committed: https://crrev.com/3daa03c0977f4314b76411519e570871ecb156dd Cr-Commit-Position: refs/heads/master@{#301417}

Patch Set 1 #

Total comments: 1

Patch Set 2 : chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M base/OWNERS View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Nico
6 years, 1 month ago (2014-10-27 17:50:32 UTC) #2
danakj
LGTM thanks
6 years, 1 month ago (2014-10-27 18:01:45 UTC) #3
danakj
https://codereview.chromium.org/686463002/diff/1/base/OWNERS File base/OWNERS (right): https://codereview.chromium.org/686463002/diff/1/base/OWNERS#newcode12 base/OWNERS:12: # Chrome is a very mature project, most things ...
6 years, 1 month ago (2014-10-27 18:02:41 UTC) #4
Nico
done, thanks
6 years, 1 month ago (2014-10-27 18:53:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686463002/20001
6 years, 1 month ago (2014-10-27 18:56:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 19:37:02 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 19:38:16 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3daa03c0977f4314b76411519e570871ecb156dd
Cr-Commit-Position: refs/heads/master@{#301417}

Powered by Google App Engine
This is Rietveld 408576698