Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 686413002: Add a script to profile chrome startup over adb, optionally with a combined systrace. (Closed)

Created:
6 years, 1 month ago by azarchs
Modified:
5 years, 10 months ago
Reviewers:
pasko, Sami
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add a script to profile chrome startup over adb, optionally with a combined systrace. Originally written by pliard@ in https://codereview.chromium.org/263163002 BUG=361548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -0 lines) Patch
A build/android/adb_profile_chrome_startup.py View 1 chunk +294 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
azarchs
6 years, 1 month ago (2014-10-30 11:45:11 UTC) #2
pasko
I added BUG= here and a reference to original Philippe's change. lgtm with a TODO ...
6 years, 1 month ago (2014-10-30 12:08:08 UTC) #4
Sami
Is there a way we could avoid duplicating all this code from adb_profile_chrome? It's 99% ...
6 years, 1 month ago (2014-10-30 13:49:09 UTC) #5
pasko
On 2014/10/30 13:49:09, Sami wrote: > Is there a way we could avoid duplicating all ...
6 years, 1 month ago (2014-10-31 09:35:02 UTC) #6
Sami
6 years, 1 month ago (2014-10-31 12:50:01 UTC) #7
On 2014/10/31 09:35:02, pasko wrote:
> On 2014/10/30 13:49:09, Sami wrote:
> > Is there a way we could avoid duplicating all this code from
> adb_profile_chrome?
> > It's 99% the same as far as I can tell. For example we could add another
> > executable script there that sets the command line and starts chrome but
> imports
> > all the identical parts from the other tool. WDYT?
> 
> As per offline discussion, azarchs@ is going to update it to share more code.

Great, thank you!

Powered by Google App Engine
This is Rietveld 408576698