Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: webkit/fileapi/file_system_url_request_job.h

Issue 6864040: Fixed file/directory url resolution for external mount point provider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/file_system_url_request_job.h
===================================================================
--- webkit/fileapi/file_system_url_request_job.h (revision 82259)
+++ webkit/fileapi/file_system_url_request_job.h (working copy)
@@ -17,6 +17,7 @@
#include "net/base/completion_callback.h"
#include "net/http/http_byte_range.h"
#include "net/url_request/url_request_job.h"
+#include "webkit/fileapi/file_system_url_request_job_base.h"
class GURL;
@@ -25,13 +26,13 @@
}
namespace fileapi {
-class FileSystemPathManager;
+class FileSystemContext;
// A request job that handles reading filesystem: URLs
-class FileSystemURLRequestJob : public net::URLRequestJob {
+class FileSystemURLRequestJob : public FileSystemURLRequestJobBase {
public:
FileSystemURLRequestJob(
- net::URLRequest* request, FileSystemPathManager* path_manager,
+ net::URLRequest* request, FileSystemContext* file_system_context,
scoped_refptr<base::MessageLoopProxy> file_thread_proxy);
// URLRequestJob methods:
@@ -46,36 +47,28 @@
// FilterContext methods (via URLRequestJob):
virtual bool GetMimeType(std::string* mime_type) const;
+ protected:
+ // FileSystemURLRequestJobBase methods.
+ virtual void DidGetLocalPath(const FilePath& local_path);
+
private:
virtual ~FileSystemURLRequestJob();
- void StartAsync();
- void DidGetRootPath(bool success, const FilePath& root_path,
- const std::string& name);
void DidResolve(base::PlatformFileError error_code,
const base::PlatformFileInfo& file_info);
void DidOpen(base::PlatformFileError error_code,
base::PassPlatformFile file, bool created);
void DidRead(int result);
- void NotifyFailed(int rv);
-
- FilePath relative_file_path_;
- FilePath absolute_file_path_;
- FileSystemPathManager* const path_manager_;
-
+ ScopedRunnableMethodFactory<FileSystemURLRequestJob> method_factory_;
+ base::ScopedCallbackFactory<FileSystemURLRequestJob> callback_factory_;
net::CompletionCallbackImpl<FileSystemURLRequestJob> io_callback_;
scoped_ptr<net::FileStream> stream_;
bool is_directory_;
scoped_ptr<net::HttpResponseInfo> response_info_;
-
- net::HttpByteRange byte_range_;
int64 remaining_bytes_;
+ net::HttpByteRange byte_range_;
- ScopedRunnableMethodFactory<FileSystemURLRequestJob> method_factory_;
- base::ScopedCallbackFactory<FileSystemURLRequestJob> callback_factory_;
- scoped_refptr<base::MessageLoopProxy> file_thread_proxy_;
-
DISALLOW_COPY_AND_ASSIGN(FileSystemURLRequestJob);
};

Powered by Google App Engine
This is Rietveld 408576698