Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2156)

Unified Diff: chrome/browser/extensions/extension_file_browser_private_api.cc

Issue 6864040: Fixed file/directory url resolution for external mount point provider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_file_browser_private_api.cc
===================================================================
--- chrome/browser/extensions/extension_file_browser_private_api.cc (revision 82259)
+++ chrome/browser/extensions/extension_file_browser_private_api.cc (working copy)
@@ -195,6 +195,10 @@
NOTREACHED();
}
+ virtual void DidGetLocalPath(const FilePath& local_path) {
+ NOTREACHED();
+ }
+
virtual void DidReadMetadata(const base::PlatformFileInfo& info,
const FilePath& unused) OVERRIDE {
NOTREACHED();
@@ -358,7 +362,7 @@
// manifest instead of the default extension icon.
GURL icon =
ExtensionIconSource::GetIconURL(extension,
- Extension::EXTENSION_ICON_SMALLISH,
+ Extension::EXTENSION_ICON_BITTY,
ExtensionIconSet::MATCH_BIGGER,
false); // grayscale
task->SetString("iconUrl", icon.spec());
@@ -396,6 +400,10 @@
NOTREACHED();
}
+ virtual void DidGetLocalPath(const FilePath& local_path) {
+ NOTREACHED();
+ }
+
virtual void DidReadMetadata(const base::PlatformFileInfo& info,
const FilePath& unused) OVERRIDE {
NOTREACHED();
@@ -477,11 +485,12 @@
return false;
}
- FilePath root_path = path_manager->GetFileSystemRootPathOnFileThread(
- file_origin_url,
- fileapi::kFileSystemTypeExternal,
- virtual_path,
- false); // create
+ FilePath root_path =
+ path_manager->ValidateFileSystemRootAndGetPathOnFileThread(
+ file_origin_url,
+ fileapi::kFileSystemTypeExternal,
+ virtual_path,
+ false); // create
FilePath final_file_path = root_path.Append(virtual_path);
// Check if this file system entry exists first.
@@ -751,7 +760,7 @@
NOTREACHED();
continue;
}
- FilePath root = path_manager->GetFileSystemRootPathOnFileThread(
+ FilePath root = path_manager->ValidateFileSystemRootAndGetPathOnFileThread(
origin_url,
fileapi::kFileSystemTypeExternal,
FilePath(virtual_path),

Powered by Google App Engine
This is Rietveld 408576698