Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 686393003: enabled enhanced bookmarks flag for all users (Closed)

Created:
6 years, 1 month ago by yefimt
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enabled enhanced bookmarks flag for all users. Enhanced bookmarks flag option was used to be shown only if user enrolled into experiment. Enabling it for all users because if user has multiple profiles there is no currently a way to enable this option properly. Long term fix would be to make about_flags aware of user preferences. For now showing to all users looks like a "lesser evil" then not giving an option to opt-out of experiment. BUG= Committed: https://crrev.com/558d1fadb000ca7ca0791398bbfc0a1cb7286a7e Cr-Commit-Position: refs/heads/master@{#302273}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -16 lines 1 comment Download

Messages

Total messages: 12 (4 generated)
yefimt
6 years, 1 month ago (2014-10-30 20:37:16 UTC) #2
Yaron
Am I reading this correctly? Doesn't this mean that it's permanently in about:flags and anybody ...
6 years, 1 month ago (2014-10-30 22:52:34 UTC) #4
Mark
On 2014/10/30 22:52:34, Yaron (OOO - On Leave) wrote: > Am I reading this correctly? ...
6 years, 1 month ago (2014-10-30 22:56:42 UTC) #5
Yaron
lgtm but please wait for Eric to approve I think this is fine from both ...
6 years, 1 month ago (2014-10-30 23:05:29 UTC) #7
noyau (Ping after 24h)
lgtm https://codereview.chromium.org/686393003/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): https://codereview.chromium.org/686393003/diff/1/chrome/browser/about_flags.cc#oldcode2131 chrome/browser/about_flags.cc:2131: #if defined(OS_ANDROID) You can put " || defined(OS_IOS) ...
6 years, 1 month ago (2014-10-31 01:43:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686393003/1
6 years, 1 month ago (2014-10-31 15:12:24 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 15:53:47 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 15:54:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/558d1fadb000ca7ca0791398bbfc0a1cb7286a7e
Cr-Commit-Position: refs/heads/master@{#302273}

Powered by Google App Engine
This is Rietveld 408576698