Add isGenericFileHandler property to FileTask.

Add isGenericFileHandler property to FileTask.
We are going to use this property from the JS side to know whether a task is generated from generic file handler or not.
Generic file handler is a file handler which can handle any type of file.

e.g.
These are generic handlers.
"types": ["*/*"]
"types": ["*"]
"types": ["*/*", "image/jpeg"]
"extensions": ["*"]
"extensions": ["*", "jpg"]

These are not generic handlers.
"types": ["image/jpeg"]
"types": ["image/*"]
"extensions": ["jpg"]
"extensions": ["jpg", "png"]

BUG=414566
TEST=out/Release/unit_tests --gtest_filter=FileManagerFileTasksTest.IsGenericFileHandler:FileManagerFileTasksComplexTest.FindFileHandlerTask_Generic

Committed: https://crrev.com/16fc34a9145b3f4f79cb4146bc7716ac4290d7d6
Cr-Commit-Position: refs/heads/master@{#302557}

[yawano, 2014-10-30 07:34:15]

yawano@chromium.org changed reviewers:
+ fukino@chromium.org

[yawano, 2014-10-30 07:34:15]

PTAL. Thanks!

[fukino, 2014-10-30 07:56:33]

Basically lgtm with a nit, but please have this reviewed by an owner of the C++
side and an owner of idl file.

https://codereview.chromium.org/686393002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/file_tasks.cc (right):

https://codereview.chromium.org/686393002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/file_tasks.cc:404: // Only show the first
matching non-generic handler from each app.
I think this comment is not correct.
Non-generic handlers are preferred, but generic handlers can be shown when
there's no non-generic handlers, right?

[yawano, 2014-10-30 08:06:18]

Thank you for the review. I fixed the comment.

https://codereview.chromium.org/686393002/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/file_tasks.cc (right):

https://codereview.chromium.org/686393002/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/file_tasks.cc:404: // Only show the first
matching non-generic handler from each app.
On 2014/10/30 07:56:33, fukino wrote:
> I think this comment is not correct.
> Non-generic handlers are preferred, but generic handlers can be shown when
> there's no non-generic handlers, right?

Yes, the comment was wrong. I fixed it.

[yawano, 2014-10-30 08:10:25]

yawano@chromium.org changed reviewers:
+ satorux@chromium.org

[yawano, 2014-10-30 08:10:26]

@satorux: PTAL this CL? Thanks!

[satorux1, 2014-10-30 08:17:21]

https://codereview.chromium.org/686393002/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/file_tasks.cc (right):

https://codereview.chromium.org/686393002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/file_tasks.cc:130: bool
IsGenericFileHandler(const extensions::FileHandlerInfo& fileHandlerInfo) {
file_handler_info

http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Variable_Names

https://codereview.chromium.org/686393002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/file_tasks.cc:134: }
Please move this out of the anonymous namespace and add a unit test.

https://codereview.chromium.org/686393002/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/file_tasks.h (right):

https://codereview.chromium.org/686393002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/file_tasks.h:182: // True if this task is
from generic file handler.
Please add some explanation about what is a generic file handler.

[yawano, 2014-10-31 01:26:30]

Thank you for the review. Added a unittest for IsGenericFileHandler. PTAL.

https://codereview.chromium.org/686393002/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/file_tasks.cc (right):

https://codereview.chromium.org/686393002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/file_tasks.cc:130: bool
IsGenericFileHandler(const extensions::FileHandlerInfo& fileHandlerInfo) {
On 2014/10/30 08:17:21, satorux1 wrote:
> file_handler_info
> 
> http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Variable_Names

Done.

https://codereview.chromium.org/686393002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/file_tasks.cc:134: }
On 2014/10/30 08:17:21, satorux1 wrote:
> Please move this out of the anonymous namespace and add a unit test.

Done.

https://codereview.chromium.org/686393002/diff/40001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/file_tasks.h (right):

https://codereview.chromium.org/686393002/diff/40001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/file_tasks.h:182: // True if this task is
from generic file handler.
On 2014/10/30 08:17:21, satorux1 wrote:
> Please add some explanation about what is a generic file handler.

Done.

[satorux1, 2014-10-31 05:57:33]

lgtm

[yawano, 2014-10-31 06:00:21]

yawano@chromium.org changed reviewers:
+ benwells@chromium.org

[yawano, 2014-10-31 06:00:21]

@benwells: PTAL this CL? Thank you!

[satorux1, 2014-10-31 06:02:55]

https://codereview.chromium.org/686393002/diff/60001/chrome/common/extensions...
File chrome/common/extensions/api/file_manager_private.idl (right):

https://codereview.chromium.org/686393002/diff/60001/chrome/common/extensions...
chrome/common/extensions/api/file_manager_private.idl:171: // True if this task
is from generic file handler.
please also add some explanation about what is a generic handler

[yawano, 2014-10-31 07:04:51]

Thanks!

https://codereview.chromium.org/686393002/diff/60001/chrome/common/extensions...
File chrome/common/extensions/api/file_manager_private.idl (right):

https://codereview.chromium.org/686393002/diff/60001/chrome/common/extensions...
chrome/common/extensions/api/file_manager_private.idl:171: // True if this task
is from generic file handler.
On 2014/10/31 06:02:55, satorux1 wrote:
> please also add some explanation about what is a generic handler

Done.

[benwells, 2014-11-03 00:13:58]

lgtm

[yawano, 2014-11-03 23:47:11]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2014-11-03 23:50:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/686393002/80001

[commit-bot: I haz the power, 2014-11-03 23:55:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-03 23:55:02]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/77154)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32 on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yawano, 2014-11-04 01:45:19]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2014-11-04 01:49:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/686393002/100001

[commit-bot: I haz the power, 2014-11-04 02:49:41]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-11-04 02:50:27]

Patchset 6 (id:??) landed as
https://crrev.com/16fc34a9145b3f4f79cb4146bc7716ac4290d7d6
Cr-Commit-Position: refs/heads/master@{#302557}