launcher_support: Gets the correct executable path for Chromium.

launcher_support: Gets the correct executable path for Chromium.

The GetAnyChromePath and GetChromePathForInstallationLevel functions
previously returned the official Google Chrome executable path, even on
Chromium. Now on a Chromium build, they will return the installed path
to Chromium, if any.

BUG=428600
Committed: https://crrev.com/ac37de0941d06e178e90a9c965bb216850ecc3c5
Cr-Commit-Position: refs/heads/master@{#302168}

[Matt Giuca, 2014-10-30 05:18:52]

mgiuca@chromium.org changed reviewers:
+ grt@chromium.org, jackhou@chromium.org, robertshield@chromium.org,
vitalybuka@chromium.org

[Matt Giuca, 2014-10-30 05:18:52]

mgiuca@chromium.org changed required reviewers:
+ grt@chromium.org

[Matt Giuca, 2014-10-30 05:18:52]

Clients affected by this (adding as optional reviewers):
gcapi's GetGoogleChromePath (robertshield)
cloud_print's chrome_launcher, service_listener and port_monitor (vitalybuka)
app_installer's GetChromeExePath (jackhou)

I can't think of a reason why you *would* want the old behaviour, though, in any
of these clients.

[Matt Giuca, 2014-10-30 05:20:07]

https://codereview.chromium.org/686383002/diff/20001/chrome/installer/launche...
File chrome/installer/launcher_support/chrome_launcher_support.cc (right):

https://codereview.chromium.org/686383002/diff/20001/chrome/installer/launche...
chrome/installer/launcher_support/chrome_launcher_support.cc:32: const wchar_t
kInstallationRegKey[] = L"Software\\Chromium";
Note: The \Software\Chromium registry key contains the same values as the
\Software\Google\Update\ClientState\<GUID> registry keys, which is why a GUID is
not required in the non-Google-Chrome case.

[Vitaly Buka (NO REVIEWS), 2014-10-30 16:52:37]

lgtm

[grt (UTC plus 2), 2014-10-30 19:15:42]

#ifdef. sigh.

[grt (UTC plus 2), 2014-10-30 19:15:59]

On 2014/10/30 19:15:42, grt wrote:
> #ifdef. sigh.

oh yeah: lgtm

[Matt Giuca, 2014-10-30 20:59:40]

On 2014/10/30 19:15:42, grt wrote:
> #ifdef. sigh.

It looks like this is the standard way to deal with Google Chrome / Chromium
discrepancies.

[Matt Giuca, 2014-10-30 20:59:48]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-10-30 21:02:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/686383002/20001

[grt (UTC plus 2), 2014-10-30 21:02:38]

On 2014/10/30 20:59:40, Matt Giuca wrote:
> On 2014/10/30 19:15:42, grt wrote:
> > #ifdef. sigh.
> 
> It looks like this is the standard way to deal with Google Chrome / Chromium
> discrepancies.

Yup. It's nicer when they can conveniently be localized to something small
rather than sprinkled about like this. At least it's all within a single file
here.

[commit-bot: I haz the power, 2014-10-30 22:05:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-30 22:05:47]

Patchset 2 (id:??) landed as
https://crrev.com/ac37de0941d06e178e90a9c965bb216850ecc3c5
Cr-Commit-Position: refs/heads/master@{#302168}