Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 686373002: Revert of Remote assistance on Chrome OS Part IV - It2MeHost (Closed)

Created:
6 years, 1 month ago by kelvinp
Modified:
6 years, 1 month ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, extensions-reviews_chromium.org, mkwst+moarreviews-ipc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Remote assistance on Chrome OS Part IV - It2MeHost (patchset #12 id:700001 of https://codereview.chromium.org/639233002/) Reason for revert: Reverting due to build failure on Linux Ozone builder. http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Builder/builds/6011 Original issue's description: > Remote assistance on Chrome OS Part IV - It2MeHost > > This CL links the it2me host to the Chrome binary on ChromeOS > behind a flag. > The following changes are made to the it2me host so that it can be run in the browser process. > 1. Initializes SSL server sockets and specific CPU media features on ChromeOS startup. > 2. Fixes a crash in it2me shutdown by making It2meHost owns the ChromotingHostContext. > 3. Replace the blocking shutdown wait on PolicyWatcher with a callback. > Implements policy_watcher on ChromeOS using policy services. > 4. Re-use existing threads, url request context getters and policy service on ChromeOS. > 5. Fixed a incorrect DCHECK regarding the color format of the frames captured on ChromeOS. > > BUG=334087 > > Committed: https://crrev.com/54dde6f02d121ff745e66b57205583087ff720ec > Cr-Commit-Position: refs/heads/master@{#302034} TBR=jochen@chromium.org,dpolukhin@chromium.org,jamiewalch@chromium.org,kalman@chromium.org,rmsousa@chromium.org,rockot@chromium.org,wez@chromium.org,agl@chromium.org NOTREECHECKS=true NOTRY=true BUG=334087 Committed: https://crrev.com/b35e7dda570c077399057d21503f97670f54313b Cr-Commit-Position: refs/heads/master@{#302036}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -541 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_host_chromeos.cc View 3 chunks +7 lines, -33 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/host/basic_desktop_environment.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M remoting/host/chromeos/aura_desktop_capturer.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/chromeos/aura_desktop_capturer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/chromoting_host_context.h View 4 chunks +9 lines, -33 lines 0 comments Download
M remoting/host/chromoting_host_context.cc View 2 chunks +47 lines, -105 lines 0 comments Download
M remoting/host/chromoting_host_context_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D remoting/host/continue_window_chromeos.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D remoting/host/disconnect_window_chromeos.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M remoting/host/it2me/it2me_host.h View 7 chunks +11 lines, -21 lines 0 comments Download
M remoting/host/it2me/it2me_host.cc View 6 chunks +20 lines, -37 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host.h View 3 chunks +7 lines, -11 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host_main.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host_unittest.cc View 4 chunks +14 lines, -12 lines 0 comments Download
M remoting/host/policy_hack/policy_watcher.h View 3 chunks +5 lines, -10 lines 0 comments Download
M remoting/host/policy_hack/policy_watcher.cc View 2 chunks +11 lines, -8 lines 0 comments Download
D remoting/host/policy_hack/policy_watcher_chromeos.cc View 1 chunk +0 lines, -90 lines 0 comments Download
M remoting/host/policy_hack/policy_watcher_linux.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/host/policy_hack/policy_watcher_mac.mm View 1 chunk +3 lines, -4 lines 0 comments Download
M remoting/host/policy_hack/policy_watcher_unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M remoting/host/policy_hack/policy_watcher_win.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 4 chunks +14 lines, -16 lines 0 comments Download
M remoting/remoting_host.gypi View 8 chunks +4 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kelvinp
Created Revert of Remote assistance on Chrome OS Part IV - It2MeHost
6 years, 1 month ago (2014-10-30 05:01:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686373002/1
6 years, 1 month ago (2014-10-30 05:01:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 05:02:30 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 05:03:17 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b35e7dda570c077399057d21503f97670f54313b
Cr-Commit-Position: refs/heads/master@{#302036}

Powered by Google App Engine
This is Rietveld 408576698