Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: snapshot/cpu_context.cc

Issue 686353004: Add MinidumpContextWriter::CreateFromSnapshot(), everything downstream, and its test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/cpu_context.h ('k') | snapshot/cpu_context_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/cpu_context.cc
diff --git a/snapshot/cpu_context.cc b/snapshot/cpu_context.cc
index eada29e45c45008bdeae2ab20d24ef4298662346..fd380c11926b7ed61ca844275bc4c98a58e64724 100644
--- a/snapshot/cpu_context.cc
+++ b/snapshot/cpu_context.cc
@@ -18,6 +18,72 @@
namespace crashpad {
+// static
+uint16_t CPUContextX86::FxsaveToFsaveTagWord(
+ uint16_t fsw,
+ uint8_t fxsave_tag,
+ const CPUContextX86::X87OrMMXRegister st_mm[8]) {
+ enum {
+ kX87TagValid = 0,
+ kX87TagZero,
+ kX87TagSpecial,
+ kX87TagEmpty,
+ };
+
+ // The x87 tag word (in both abridged and full form) identifies physical
+ // registers, but |st_mm| is arranged in logical stack order. In order to map
+ // physical tag word bits to the logical stack registers they correspond to,
+ // the “stack top” value from the x87 status word is necessary.
+ int stack_top = (fsw >> 11) & 0x7;
+
+ uint16_t fsave_tag = 0;
+ for (int physical_index = 0; physical_index < 8; ++physical_index) {
+ bool fxsave_bit = fxsave_tag & (1 << physical_index);
+ uint8_t fsave_bits;
+
+ if (fxsave_bit) {
+ int st_index = (physical_index + 8 - stack_top) % 8;
+ const CPUContextX86::X87Register& st = st_mm[st_index].st;
+
+ uint32_t exponent = ((st[9] & 0x7f) << 8) | st[8];
+ if (exponent == 0x7fff) {
+ // Infinity, NaN, pseudo-infinity, or pseudo-NaN. If it was important to
+ // distinguish between these, the J bit and the M bit (the most
+ // significant bit of |fraction|) could be consulted.
+ fsave_bits = kX87TagSpecial;
+ } else {
+ // The integer bit the “J bit”.
+ bool integer_bit = st[7] & 0x80;
+ if (exponent == 0) {
+ uint64_t fraction = ((static_cast<uint64_t>(st[7]) & 0x7f) << 56) |
+ (static_cast<uint64_t>(st[6]) << 48) |
+ (static_cast<uint64_t>(st[5]) << 40) |
+ (static_cast<uint64_t>(st[4]) << 32) |
+ (static_cast<uint32_t>(st[3]) << 24) |
+ (st[2] << 16) | (st[1] << 8) | st[0];
+ if (!integer_bit && fraction == 0) {
+ fsave_bits = kX87TagZero;
+ } else {
+ // Denormal (if the J bit is clear) or pseudo-denormal.
+ fsave_bits = kX87TagSpecial;
+ }
+ } else if (integer_bit) {
+ fsave_bits = kX87TagValid;
+ } else {
+ // Unnormal.
+ fsave_bits = kX87TagSpecial;
+ }
+ }
+ } else {
+ fsave_bits = kX87TagEmpty;
+ }
+
+ fsave_tag |= (fsave_bits << (physical_index * 2));
+ }
+
+ return fsave_tag;
+}
+
uint64_t CPUContext::InstructionPointer() const {
switch (architecture) {
case kCPUArchitectureX86:
« no previous file with comments | « snapshot/cpu_context.h ('k') | snapshot/cpu_context_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698