Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6024)

Unified Diff: chrome/browser/ui/views/profiles/avatar_menu_button.cc

Issue 686353002: Fix transparent avatar icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add TODO(noms) Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/profiles/avatar_menu_button.cc
diff --git a/chrome/browser/ui/views/profiles/avatar_menu_button.cc b/chrome/browser/ui/views/profiles/avatar_menu_button.cc
index 7768d1c890b558be88a4a51f126360477bc48c43..65d8452a84464aef9d1cbe52f3460661dee7c963 100644
--- a/chrome/browser/ui/views/profiles/avatar_menu_button.cc
+++ b/chrome/browser/ui/views/profiles/avatar_menu_button.cc
@@ -123,6 +123,17 @@ void AvatarMenuButton::GetAvatarImages(Profile* profile,
if (switches::IsNewAvatarMenu()) {
*avatar = cache.GetAvatarIconOfProfileAtIndex(index);
+ // TODO(noms): Once the code for the old avatar menu button is removed,
+ // this function will only be called for badging the taskbar icon. The
+ // function can be renamed to something like GetAvatarImageForBadging()
+ // and only needs to return the avatar from
+ // AvatarMenu::GetImageForMenuButton().
+#if !defined(OS_CHROMEOS)
+ bool is_badge_rectangle = false;
+ AvatarMenu::GetImageForMenuButton(profile,
+ taskbar_badge_avatar,
+ &is_badge_rectangle);
+#endif
} else {
AvatarMenu::GetImageForMenuButton(profile, avatar, is_rectangle);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698