Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2128)

Unified Diff: net/url_request/url_request_filter.cc

Issue 686343002: Add MaybeInterceptRedirect/Response to URLRequestInterceptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added tests, removed DRP Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_filter.cc
diff --git a/net/url_request/url_request_filter.cc b/net/url_request/url_request_filter.cc
index eaa3325fba38b1a13af28db2340b0902f99f1546..3236e2d453e0a0f8cefe5aaf4811b735eb2ae2e7 100644
--- a/net/url_request/url_request_filter.cc
+++ b/net/url_request/url_request_filter.cc
@@ -23,10 +23,23 @@ class URLRequestFilterInterceptor : public URLRequestInterceptor {
// URLRequestInterceptor implementation.
URLRequestJob* MaybeInterceptRequest(
URLRequest* request,
- NetworkDelegate* network_delegate) const override {
+ NetworkDelegate* network_delegate) override {
return factory_(request, network_delegate, request->url().scheme());
}
+ URLRequestJob* MaybeInterceptRedirect(
+ URLRequest* request,
+ NetworkDelegate* network_delegate,
+ const GURL& location) override {
+ return NULL;
+ }
+
+ URLRequestJob* MaybeInterceptResponse(
+ URLRequest* request,
+ NetworkDelegate* network_delegate) override {
+ return NULL;
+ }
+
private:
URLRequest::ProtocolFactory* factory_;
@@ -129,7 +142,7 @@ void URLRequestFilter::ClearHandlers() {
URLRequestJob* URLRequestFilter::MaybeInterceptRequest(
URLRequest* request,
- NetworkDelegate* network_delegate) const {
+ NetworkDelegate* network_delegate) {
URLRequestJob* job = NULL;
if (!request->url().is_valid())
return NULL;
@@ -157,6 +170,19 @@ URLRequestJob* URLRequestFilter::MaybeInterceptRequest(
return job;
}
+URLRequestJob* URLRequestFilter::MaybeInterceptRedirect(
+ URLRequest* request,
+ NetworkDelegate* network_delegate,
+ const GURL& location) {
+ return NULL;
+}
+
+URLRequestJob* URLRequestFilter::MaybeInterceptResponse(
+ URLRequest* request,
+ NetworkDelegate* network_delegate) {
+ return NULL;
+}
+
URLRequestFilter::URLRequestFilter() : hit_count_(0) {
URLRequestJobFactoryImpl::SetInterceptorForTesting(this);
}

Powered by Google App Engine
This is Rietveld 408576698