Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: android_webview/native/android_protocol_handler.cc

Issue 686343002: Add MaybeInterceptRedirect/Response to URLRequestInterceptor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added tests, removed DRP Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/android_protocol_handler.cc
diff --git a/android_webview/native/android_protocol_handler.cc b/android_webview/native/android_protocol_handler.cc
index 4bdf6ecbb6737788a5768470a9f56ed424135c65..d91e14e40de3e7bdf596581df96a1c7647ec4aad 100644
--- a/android_webview/native/android_protocol_handler.cc
+++ b/android_webview/native/android_protocol_handler.cc
@@ -88,7 +88,16 @@ class AndroidRequestInterceptorBase : public net::URLRequestInterceptor {
public:
virtual net::URLRequestJob* MaybeInterceptRequest(
net::URLRequest* request,
- net::NetworkDelegate* network_delegate) const override;
+ net::NetworkDelegate* network_delegate) override;
+
+ virtual net::URLRequestJob* MaybeInterceptRedirect(
+ net::URLRequest* request,
+ net::NetworkDelegate* network_delegate,
+ const GURL& location) override;
+
+ virtual net::URLRequestJob* MaybeInterceptResponse(
+ net::URLRequest* request,
+ net::NetworkDelegate* network_delegate) override;
virtual bool ShouldHandleRequest(const net::URLRequest* request) const = 0;
};
@@ -212,7 +221,7 @@ void AndroidStreamReaderURLRequestJobDelegateImpl::AppendResponseHeaders(
net::URLRequestJob* AndroidRequestInterceptorBase::MaybeInterceptRequest(
net::URLRequest* request,
- net::NetworkDelegate* network_delegate) const {
+ net::NetworkDelegate* network_delegate) {
if (!ShouldHandleRequest(request))
return NULL;
@@ -236,6 +245,19 @@ net::URLRequestJob* AndroidRequestInterceptorBase::MaybeInterceptRequest(
request, network_delegate, reader_delegate.Pass());
}
+net::URLRequestJob* AndroidRequestInterceptorBase::MaybeInterceptRedirect(
+ net::URLRequest* request,
+ net::NetworkDelegate* network_delegate,
+ const GURL& location) {
+ return NULL;
+}
+
+net::URLRequestJob* AndroidRequestInterceptorBase::MaybeInterceptResponse(
+ net::URLRequest* request,
+ net::NetworkDelegate* network_delegate) {
+ return NULL;
+}
+
// AssetFileRequestInterceptor ------------------------------------------------
AssetFileRequestInterceptor::AssetFileRequestInterceptor()

Powered by Google App Engine
This is Rietveld 408576698