Hotword Private API: Adds speech training functions.

Hotword Private API: Adds speech training functions.

BUG=397019, 390086
Committed: https://crrev.com/df338050bb40f33fa9934b9da390e7f6823e251e
Cr-Commit-Position: refs/heads/master@{#302409}

[kcarattini, 2014-10-30 00:49:19]

kcarattini@chromium.org changed reviewers:
+ jhawkins@chromium.org, mpearson@chromium.org, rlp@chromium.org

[kcarattini, 2014-10-30 00:49:19]

mpearson@chromium.org: Please review changes in histograms.xml and
extension_function_histogram-value.h

jhawkins@chromium.org: Please review changes in
chrome/browser/extensions/api/...
chrome/browser/ui/webui/...
chrome/common/extensions/api/...
chrome/test/data/extensions/api/...

[Mark P, 2014-10-30 01:03:38]

histograms.xml and extension_function_histogram-value.h lgtm

[James Hawkins, 2014-10-30 18:20:07]

On 2014/10/30 00:49:19, kcarattini wrote:
> mailto:mpearson@chromium.org: Please review changes in histograms.xml and
> extension_function_histogram-value.h
> 
> mailto:jhawkins@chromium.org: Please review changes in
> chrome/browser/extensions/api/...

Please find an OWNER from chrome/browser/extensions/OWNERS.

> chrome/browser/ui/webui/...

webui LGTM

> chrome/common/extensions/api/...

Please find an OWNER from chrome/common/extensions/OWNERS.

> chrome/test/data/extensions/api/...

Please find an OWNER from chrome/test/OWNERS.

[rpetterson, 2014-10-30 19:48:36]

https://codereview.chromium.org/686333002/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/hotword_private/hotword_private_api.cc
(right):

https://codereview.chromium.org/686333002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/hotword_private/hotword_private_api.cc:68:
pref_name == std::string(
Why is this a part of OnEnabledChanged? I would expect a different event for the
training state.

https://codereview.chromium.org/686333002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/hotword_private/hotword_private_api.cc:150: if
(hotword_service) {
Group this if statement with the one above.

[kcarattini, 2014-10-30 23:44:19]

https://codereview.chromium.org/686333002/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/hotword_private/hotword_private_api.cc
(right):

https://codereview.chromium.org/686333002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/hotword_private/hotword_private_api.cc:68:
pref_name == std::string(
On 2014/10/30 19:48:36, rpetterson wrote:
> Why is this a part of OnEnabledChanged? I would expect a different event for
the
> training state.

Changed the comment in hotword_private.idl, as discussed.

https://codereview.chromium.org/686333002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/hotword_private/hotword_private_api.cc:150: if
(hotword_service) {
On 2014/10/30 19:48:35, rpetterson wrote:
> Group this if statement with the one above.

Done.

[kcarattini, 2014-10-30 23:47:51]

kcarattini@chromium.org changed reviewers:
+ benwells@chromium.org, sky@chromium.org

[kcarattini, 2014-10-30 23:47:51]

sky@, please review changes in chrome/test/...

benwells@, please review changes in chrome/browser/extensions/... and
chrome/common/extensions/...

[rpetterson, 2014-10-30 23:51:37]

lgtm

[sky, 2014-10-31 15:56:46]

On 2014/10/30 23:47:51, kcarattini wrote:
> sky@, please review changes in chrome/test/...

You only have changes in chrome/test/data/ chrome/test/data has an OWNERS of *,
so you don't need me (and I'm not a good reviewer for these changes anyway).

> benwells@, please review changes in chrome/browser/extensions/... and
> chrome/common/extensions/...

[sky, 2014-10-31 15:56:54]

sky@chromium.org changed reviewers:
- sky@chromium.org

[chromium-reviews, 2014-11-03 00:15:59]

Ok.

Ben, just waiting for you now :)


Kendra

On Sat, Nov 1, 2014 at 2:56 AM, <sky@chromium.org> wrote:

> On 2014/10/30 23:47:51, kcarattini wrote:
>
>> sky@, please review changes in chrome/test/...
>>
>
> You only have changes in chrome/test/data/ chrome/test/data has an OWNERS
> of *,
> so you don't need me (and I'm not a good reviewer for these changes
> anyway).
>
>
>  benwells@, please review changes in chrome/browser/extensions/... and
>> chrome/common/extensions/...
>>
>
>
>
> https://codereview.chromium.org/686333002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[benwells, 2014-11-03 00:19:59]

lgtm

[kcarattini, 2014-11-03 00:21:43]

The CQ bit was checked by kcarattini@chromium.org

[commit-bot: I haz the power, 2014-11-03 00:22:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/686333002/60001

[commit-bot: I haz the power, 2014-11-03 01:20:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-11-03 01:20:25]

Patchset 4 (id:??) landed as
https://crrev.com/df338050bb40f33fa9934b9da390e7f6823e251e
Cr-Commit-Position: refs/heads/master@{#302409}