Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: sdk/lib/_internal/pub/test/validator/sdk_constraint_test.dart

Issue 686323002: Add support for ^ constraints in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/validator/sdk_constraint_test.dart
diff --git a/sdk/lib/_internal/pub/test/validator/sdk_constraint_test.dart b/sdk/lib/_internal/pub/test/validator/sdk_constraint_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..4efb822037812bc33d33ca2634b05f00682a9310
--- /dev/null
+++ b/sdk/lib/_internal/pub/test/validator/sdk_constraint_test.dart
@@ -0,0 +1,48 @@
+// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'dart:async';
+import 'dart:convert';
+
+import 'package:http/http.dart' as http;
+import 'package:http/testing.dart';
+import 'package:path/path.dart' as path;
+import 'package:scheduled_test/scheduled_test.dart';
+
+import '../../lib/src/entrypoint.dart';
+import '../../lib/src/validator.dart';
+import '../../lib/src/validator/sdk_constraint.dart';
+import '../descriptor.dart' as d;
+import '../test_pub.dart';
+import 'utils.dart';
+
+Validator sdkConstraint(Entrypoint entrypoint) =>
+ new SdkConstraintValidator(entrypoint);
+
+main() {
+ initConfig();
+
+ group('should consider a package valid if it', () {
+ integration('has no SDK constraint', () {
+ d.validPackage.create();
+ expectNoValidationError(sdkConstraint);
+ });
+
+ integration('has an SDK constraint without ^', () {
+ d.dir(appPath, [
+ d.libPubspec("test_pkg", "1.0.0", sdk: ">=1.8.0 <2.0.0")
+ ]).create();
+ expectNoValidationError(sdkConstraint);
+ });
+ });
+
+ test("should consider a package invalid if it has an SDK constraint with "
+ "^", () {
+ d.dir(appPath, [
+ d.libPubspec("test_pkg", "1.0.0", sdk: "^1.8.0")
+ ]).create();
+ expect(schedulePackageValidation(sdkConstraint),
+ completion(pairOf(anyElement(contains('">=1.8.0 <2.0.0"')), isEmpty)));
+ });
+}
« no previous file with comments | « sdk/lib/_internal/pub/test/validator/dependency_test.dart ('k') | sdk/lib/_internal/pub_generated/lib/src/validator.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698