Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 686293003: FrameView's size should be calculated based on contentWidth+scrollbarWidth (Closed)

Created:
6 years, 1 month ago by bokan
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

FrameView's size should be calculated based on contentWidth+scrollbarWidth In virtual viewport mode, the main FrameView's size is calculated based on the content width of the page. On platforms where scrollbars take up layout space (non-overlay scrollbars), this should include the scrollbar width as well as the content width since the PinchViewport encompasses both when fully zoomed out and the PinchViewport is bounded by the outer viewport. BUG=148816 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M Source/web/PageScaleConstraintsSet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PageScaleConstraintsSet.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bokan
This was causing problems in layout tests. I think it's more correct in general but ...
6 years, 1 month ago (2014-10-30 16:59:18 UTC) #2
aelias_OOO_until_Jul13
lgtm
6 years, 1 month ago (2014-10-30 20:52:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686293003/1
6 years, 1 month ago (2014-10-30 21:11:58 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 01:20:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184682

Powered by Google App Engine
This is Rietveld 408576698