content/common/gpu/media/vaapi_video_encode_accelerator.cc - Issue 686283002: Vaapi VEA: always generate IDR when keyframe is requested.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/vaapi_video_encode_accelerator.cc

Issue 686283002: Vaapi VEA: always generate IDR when keyframe is requested. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test failure - forgot to set current_encode_job_->keyframe. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/gpu/media/vaapi_video_encode_accelerator.cc

diff --git a/content/common/gpu/media/vaapi_video_encode_accelerator.cc b/content/common/gpu/media/vaapi_video_encode_accelerator.cc

index 14ffe34355012f74e4ce4e72c13f24ae8b915b7a..19e1c0820dd1b4d7c741e30935cee9de30f7de28 100644

--- a/content/common/gpu/media/vaapi_video_encode_accelerator.cc

+++ b/content/common/gpu/media/vaapi_video_encode_accelerator.cc

@@ -291,7 +291,7 @@ void VaapiVideoEncodeAccelerator::BeginFrame(bool force_keyframe) {

else

current_pic_.type = media::H264SliceHeader::kPSlice;

- if (current_pic_.frame_num % idr_period_ == 0) {

+ if (current_pic_.frame_num % idr_period_ == 0 || force_keyframe) {

current_pic_.idr = true;

last_idr_frame_num_ = current_pic_.frame_num;

ref_pic_list0_.clear();

@@ -304,8 +304,7 @@ void VaapiVideoEncodeAccelerator::BeginFrame(bool force_keyframe) {

current_pic_.top_field_order_cnt = current_pic_.pic_order_cnt;

current_pic_.pic_order_cnt_lsb = current_pic_.pic_order_cnt;

- current_encode_job_->keyframe =

- (current_pic_.type == media::H264SliceHeader::kISlice);

+ current_encode_job_->keyframe = current_pic_.idr;

DVLOGF(4) << "Starting a new frame, type: " << current_pic_.type

<< (force_keyframe ? " (forced keyframe)" : "")

« no previous file with comments | « no previous file | content/common/gpu/media/video_encode_accelerator_unittest.cc » ('j') | no next file with comments »