Vaapi VEA: always generate IDR when keyframe is requested.

content/common/gpu/media/video_encode_accelerator_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/at_exit.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/files/memory_mapped_file.h"
 #include "base/memory/scoped_vector.h"
@@ skipping 374 matching lines @@
         ASSERT_TRUE(seen_sps_);
         ASSERT_TRUE(seen_pps_);
         seen_idr_ = true;
         // fallthrough
       case media::H264NALU::kNonIDRSlice: {
         ASSERT_TRUE(seen_idr_);
 
         media::H264SliceHeader shdr;
         ASSERT_EQ(media::H264Parser::kOk,
                   h264_parser_.ParseSliceHeader(nalu, &shdr));
-        keyframe = shdr.IsISlice() || shdr.IsSISlice();
+
+        if (nalu.nal_unit_type == media::H264NALU::kIDRSlice) {
+          ASSERT_TRUE(shdr.IsISlice() || shdr.IsSISlice());
+          keyframe = true;

[Pawel Osciak, 2014/10/30 01:38:33]

Please instead move keyframe = true to the case above. And then I/SI slice
detection won't be needed.

[hshi1, 2014/10/30 03:48:25]

Done.

+        }
 
         if (!frame_cb_.Run(keyframe))
           return;
         break;
       }
 
       case media::H264NALU::kSPS: {
         int sps_id;
         ASSERT_EQ(media::H264Parser::kOk, h264_parser_.ParseSPS(&sps_id));
         seen_sps_ = true;
@@ skipping 797 matching lines @@
   }
 
   content::g_env =
       reinterpret_cast<content::VideoEncodeAcceleratorTestEnvironment*>(
           testing::AddGlobalTestEnvironment(
               new content::VideoEncodeAcceleratorTestEnvironment(
                   test_stream_data.Pass())));
 
   return RUN_ALL_TESTS();
 }