Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 686223002: Move ResourcePrefetchPredictor histograms from interal repo to open source repo (Closed)

Created:
6 years, 1 month ago by Zhen Wang
Modified:
6 years, 1 month ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move ResourcePrefetchPredictor histograms from interal repo to open source repo This update includes the ones used in CL 576313002 (https://codereview.chromium.org/576313002/). BUG=405690, 406200 Committed: https://crrev.com/5680ee4b983e19166e9e7969f54ba2ee7d6d4064 Cr-Commit-Position: refs/heads/master@{#302201}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Mechanical move from google3 to chromium #

Unified diffs Side-by-side diffs Delta from patch set Stats (+661 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 3 chunks +661 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
Zhen Wang
Hi Alexei, This is the CL includes the UMAs I separate from CL 632033002. ptal. ...
6 years, 1 month ago (2014-10-29 21:03:11 UTC) #2
Alexei Svitkine (slow)
Can you send a corresponding CL to remove them from the internal histograms.xml file?
6 years, 1 month ago (2014-10-29 21:53:33 UTC) #3
Zhen Wang
Done. Please see: http://cr/78794848
6 years, 1 month ago (2014-10-29 22:39:52 UTC) #4
Alexei Svitkine (slow)
https://codereview.chromium.org/686223002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/686223002/diff/20001/tools/metrics/histograms/histograms.xml#newcode51656 tools/metrics/histograms/histograms.xml:51656: +<enum name="ResourcePrefetchPredictorResourceStatus" type="int"> It doesn't seem like the diff ...
6 years, 1 month ago (2014-10-30 13:55:35 UTC) #5
Zhen Wang
https://codereview.chromium.org/686223002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/686223002/diff/20001/tools/metrics/histograms/histograms.xml#newcode51656 tools/metrics/histograms/histograms.xml:51656: +<enum name="ResourcePrefetchPredictorResourceStatus" type="int"> This seems to be missing from ...
6 years, 1 month ago (2014-10-30 14:13:08 UTC) #6
Zhen Wang
I have changed it to a mechanical move from google3 to chromium. ptal.
6 years, 1 month ago (2014-10-30 16:14:51 UTC) #7
Alexei Svitkine (slow)
LGTM, thanks
6 years, 1 month ago (2014-10-30 16:24:24 UTC) #8
Zhen Wang
How do I commit this CL? The commit check box is gray and cannot be ...
6 years, 1 month ago (2014-10-30 16:38:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686223002/40001
6 years, 1 month ago (2014-10-30 21:34:09 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/1515)
6 years, 1 month ago (2014-10-30 22:48:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686223002/40001
6 years, 1 month ago (2014-10-31 00:44:53 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-31 00:45:45 UTC) #16
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 00:46:15 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5680ee4b983e19166e9e7969f54ba2ee7d6d4064
Cr-Commit-Position: refs/heads/master@{#302201}

Powered by Google App Engine
This is Rietveld 408576698