Make WebContentsObserver pass more calls to Java.

Make WebContentsObserver pass more calls to Java.

BUG=428791
Committed: https://crrev.com/26b20683169e7cf85cfdf6119b3f819ee799acb8
Cr-Commit-Position: refs/heads/master@{#304613}

[Mathias Hällman, 2014-10-30 15:30:19]

mathiash@opera.com changed reviewers:
+ tedchoc@chromium.org

[Mathias Hällman, 2014-11-05 09:50:44]

mathiash@opera.com changed reviewers:
+ benm@chromium.org, skyostil@chromium.org

[Mathias Hällman, 2014-11-05 10:06:13]

On 2014/10/30 15:30:29, Mathias Hällman wrote:


skyostil, benm, can you two have a look? skyostil for content/browser/ and benm
for content/public/. Or tedchoc for / if you're around of course. :)

[Ted C, 2014-11-05 16:26:04]

https://codereview.chromium.org/686213003/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java
(right):

https://codereview.chromium.org/686213003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java:106:
public void documentAvailableInMainFrame() {
Can you add javadoc to these new methods?

[Mathias Hällman, 2014-11-06 10:05:24]

On 2014/11/05 16:26:04, Ted C wrote:
>
https://codereview.chromium.org/686213003/diff/1/content/public/android/java/...
> File
>
content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java
> (right):
> 
>
https://codereview.chromium.org/686213003/diff/1/content/public/android/java/...
>
content/public/android/java/src/org/chromium/content/browser/WebContentsObserver.java:106:
> public void documentAvailableInMainFrame() {
> Can you add javadoc to these new methods?

Added javadoc saying basically what the base class header is saying.

[Ted C, 2014-11-07 18:51:58]

lgtm

[Sami, 2014-11-07 18:54:10]

lgtm ++

[Mathias Hällman, 2014-11-07 18:59:33]

The CQ bit was checked by mathiash@opera.com

[commit-bot: I haz the power, 2014-11-07 19:00:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/686213003/20001

[commit-bot: I haz the power, 2014-11-07 19:14:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-07 19:15:02]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Mathias Hällman, 2014-11-07 20:05:25]

The CQ bit was checked by mathiash@opera.com

[commit-bot: I haz the power, 2014-11-07 20:05:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/686213003/40001

[commit-bot: I haz the power, 2014-11-07 20:24:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-07 20:24:18]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Mathias Hällman, 2014-11-18 07:57:38]

On 2014/11/07 20:24:18, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   android_aosp on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
>   android_chromium_gn_compile_dbg on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
>   android_chromium_gn_compile_rel on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)


tedchoc, could you have another look at
content/browser/android/web_contents_observer_android.cc please?

[Sami, 2014-11-18 13:26:28]

content/browser/android/web_contents_observer_android.cc lgtm.

[Mathias Hällman, 2014-11-18 14:10:05]

The CQ bit was checked by mathiash@opera.com

[commit-bot: I haz the power, 2014-11-18 14:10:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/686213003/60001

[commit-bot: I haz the power, 2014-11-18 16:02:04]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-11-18 16:03:17]

Patchset 4 (id:??) landed as
https://crrev.com/26b20683169e7cf85cfdf6119b3f819ee799acb8
Cr-Commit-Position: refs/heads/master@{#304613}