Mojo JS Bindings: Simplify sharing services for content-provided JS applications

mojo/bindings/js/handle.cc

Index: mojo/bindings/js/handle.cc
diff --git a/mojo/bindings/js/handle.cc b/mojo/bindings/js/handle.cc
index 37384d6cbcb5222bece45ebf045ad3e312b54655..af2b4c28b0bda56d91308778e34bba89da4e90e1 100644
--- a/mojo/bindings/js/handle.cc
+++ b/mojo/bindings/js/handle.cc
@@ -86,4 +86,29 @@ bool Converter<mojo::Handle>::FromV8(v8::Isolate* isolate,
   return true;
 }
 
+v8::Handle<v8::Value> Converter<mojo::MessagePipeHandle>::ToV8(

[Aaron Boodman, 2014/10/29 23:06:29]

You can just delegate to the converter for mojo::Handle:

return Converter<mojo::Handle>::ToV8(isolate, val);

Same for FromV8.

[hansmuller, 2014/10/30 00:23:38]

Good point!

+    v8::Isolate* isolate, mojo::MessagePipeHandle val) {
+  if (!val.is_valid())
+    return v8::Null(isolate);
+  return mojo::js::HandleWrapper::Create(isolate, val.value()).ToV8();
+}
+
+bool Converter<mojo::MessagePipeHandle>::FromV8(v8::Isolate* isolate,
+                                                v8::Handle<v8::Value> val,
+                                                mojo::MessagePipeHandle* out) {
+  if (val->IsNull()) {
+    *out = mojo::MessagePipeHandle();
+    return true;
+  }
+
+  gin::Handle<mojo::js::HandleWrapper> handle;
+  if (!Converter<gin::Handle<mojo::js::HandleWrapper> >::FromV8(
+      isolate, val, &handle))
+    return false;
+
+  *out = mojo::MessagePipeHandle(handle->get().value());
+  return true;
+}
+
+
 }  // namespace gin