Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Unified Diff: mojo/apps/js/application_delegate_impl.cc

Issue 686203004: Mojo JS Bindings: Simplify sharing services for content-provided JS applications (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/apps/js/application_delegate_impl.cc
diff --git a/mojo/apps/js/application_delegate_impl.cc b/mojo/apps/js/application_delegate_impl.cc
index f197c3cc0eb82e2eaa357783c94b32dfb9ef6709..746ddcc0eb3077d0387c5b5fa22ca267ac365298 100644
--- a/mojo/apps/js/application_delegate_impl.cc
+++ b/mojo/apps/js/application_delegate_impl.cc
@@ -41,15 +41,12 @@ void ApplicationDelegateImpl::QuitJSApp(JSApp* app) {
base::MessageLoop::current()->QuitNow();
}
-void ApplicationDelegateImpl::ConnectToService(
- ScopedMessagePipeHandle pipe_handle,
+void ApplicationDelegateImpl::ConnectToApplication(
const std::string& application_url,
- const std::string& interface_name) {
+ InterfaceRequest<ServiceProvider> request) {
CHECK(application_impl_);
- ServiceProvider* service_provider =
- application_impl_->ConnectToApplication(application_url)
- ->GetServiceProvider();
- service_provider->ConnectToService(interface_name, pipe_handle.Pass());
+ application_impl_->shell()->ConnectToApplication(application_url,
+ request.Pass());
}
} // namespace apps

Powered by Google App Engine
This is Rietveld 408576698