Mojo JS Bindings: Simplify sharing services for content-provided JS applications

mojo/bindings/js/handle.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/bindings/js/handle.h"
 
 #include <sstream>
 #include "mojo/bindings/js/handle_close_observer.h"
 
 namespace mojo {
@@ skipping 68 matching lines @@
 
   gin::Handle<mojo::js::HandleWrapper> handle;
   if (!Converter<gin::Handle<mojo::js::HandleWrapper> >::FromV8(
       isolate, val, &handle))
     return false;
 
   *out = handle->get();
   return true;
 }
 
+v8::Handle<v8::Value> Converter<mojo::MessagePipeHandle>::ToV8(

[Aaron Boodman, 2014/10/29 23:06:29]

You can just delegate to the converter for mojo::Handle:

return Converter<mojo::Handle>::ToV8(isolate, val);

Same for FromV8.

[hansmuller, 2014/10/30 00:23:38]

Good point!

+    v8::Isolate* isolate, mojo::MessagePipeHandle val) {
+  if (!val.is_valid())
+    return v8::Null(isolate);
+  return mojo::js::HandleWrapper::Create(isolate, val.value()).ToV8();
+}
+
+bool Converter<mojo::MessagePipeHandle>::FromV8(v8::Isolate* isolate,
+                                                v8::Handle<v8::Value> val,
+                                                mojo::MessagePipeHandle* out) {
+  if (val->IsNull()) {
+    *out = mojo::MessagePipeHandle();
+    return true;
+  }
+
+  gin::Handle<mojo::js::HandleWrapper> handle;
+  if (!Converter<gin::Handle<mojo::js::HandleWrapper> >::FromV8(
+      isolate, val, &handle))
+    return false;
+
+  *out = mojo::MessagePipeHandle(handle->get().value());
+  return true;
+}
+
+
 }  // namespace gin