Issue 686193004: Changed free(buffer) to delete [] buffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 686193004: Changed free(buffer) to delete [] buffer (Closed)

Created:
6 years, 1 month ago by brucedawson

Modified:
6 years, 1 month ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Changed free(buffer) to delete [] buffer. This bug (mismatch between new[] and free) was found by running VC++'s /analyze on all of Chrome. BUG=chromium:427616 LOG=N R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25003

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/objects-printer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Yang

On 2014/10/30 00:15:35, brucedawson wrote: LGTM. Thanks for finding this! I'll land this patch.

6 years, 1 month ago (2014-10-30 07:36:17 UTC) #3

Yang

6 years, 1 month ago (2014-10-30 07:41:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 25003 (presubmit successful).