Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 686183002: Revert of Refactor RtcDataChannelHandler. (Closed)

Created:
6 years, 1 month ago by csharp
Modified:
6 years, 1 month ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor RtcDataChannelHandler. (patchset #2 id:20001 of https://codereview.chromium.org/643693007/) Reason for revert: Broke some webrtc tests on win7 Original issue's description: > Refactor RtcDataChannelHandler. > This change splits the WebRtc observer functionality of RtcDataChannelHandler > from the WebKit related functionality. The former belongs with libjingle's > signaling thread and the latter with the main thread. As is, these threads > are one and the same, but this will change later this week. > > BUG=369796 > > Committed: https://crrev.com/832aa011fa8f98972f04468216dd2fbbd3e7ca42 > Cr-Commit-Position: refs/heads/master@{#301831} TBR=perkj@chromium.org,tommi@chromium.org NOTREECHECKS=true NOTRY=true BUG=369796 Committed: https://crrev.com/e5c86de0b8af3f3e913408c8ad7dca57a894ba6d Cr-Commit-Position: refs/heads/master@{#301846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -193 lines) Patch
M content/renderer/media/rtc_data_channel_handler.h View 3 chunks +9 lines, -52 lines 0 comments Download
M content/renderer/media/rtc_data_channel_handler.cc View 4 chunks +32 lines, -136 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
csharp
Created Revert of Refactor RtcDataChannelHandler.
6 years, 1 month ago (2014-10-29 15:59:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/686183002/1
6 years, 1 month ago (2014-10-29 16:00:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 16:01:23 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 16:02:14 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5c86de0b8af3f3e913408c8ad7dca57a894ba6d
Cr-Commit-Position: refs/heads/master@{#301846}

Powered by Google App Engine
This is Rietveld 408576698