Issue 686163002: Oilpan: pull SVGPropertyBase off the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 686163002: Oilpan: pull SVGPropertyBase off the heap. (Closed)

Created:
6 years, 1 month ago by sof

Modified:
6 years, 1 month ago

Reviewers:
oilpan-reviews, haraken, kouhei (in TOK)

CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: pull SVGPropertyBase off the heap. Having the SVG property base class derive from RefCountedGarbageCollected, but its derived classes all be created and kept as ref-counted pointers doesn't bring any benefits. Revert back to deriving from RefCounted<> until the entire SVG property hierarchy can be moved to the Oilpan heap, and ref-counts be avoided altogether for these objects. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184600